8000 BUG : ValueError in case on NaN value in groupby columns by cgangwar11 · Pull Request #24850 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

BUG : ValueError in case on NaN value in groupby columns #24850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 22, 2019
Merged

BUG : ValueError in case on NaN value in groupby columns #24850

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
65d05f7
BUG
cgangwar11 Jan 20, 2019
ee1c9af
minor_documentation_fix
cgangwar11 Jan 21, 2019
16531ec
Using literal observed value
cgangwar11 Jan 21, 2019
0fe8678
Modified previous test case and added new one for 21151
cgangwar11 Jan 22, 2019
e397a5a
whatsnew changes
cgangwar11 Jan 22, 2019
e2badda
minor changes
cgangwar11 Jan 22, 2019
8d5b896
minor changes
cgangwar11 Jan 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor_documentation_fix
  • Loading branch information
@cgangwar11
cgangwar11 committed Jan 21, 2019
commit ee1c9af72d2490c5ee342fd96a9b0937b015f1a0
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v0.24.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1782,7 +1782,7 @@ Groupby/Resample/Rolling
- Bug in :meth:`DataFrame.groupby` did not respect the ``observed`` argument when selecting a column and instead always used ``observed=False`` (:issue:`23970`)
- Bug in :func:`pandas.core.groupby.SeriesGroupBy.pct_change` or :func:`pandas.core.groupby.DataFrameGroupBy.pct_change` would previously work across groups when calculating the percent change, where it now correctly works per group (:issue:`21200`, :issue:`21235`).
- Bug preventing hash table creation with very large number (2^32) of rows (:issue:`22805`)
- Bug in :meth: `pandas.core.groupby.groups` which casues ``ValueError`` if ``observed=True`` and ``nan`` is present in group column (:issue:`22805`)
- Bug in :meth: `pandas.core.groupby.groups` which casues ``ValueError`` if ``observed=True`` and ``nan`` is present in group column (:issue:`22805`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pandas.core.groupby.groups isn't a method. How about just "Bug in groupby causing a ValueError if ..."


Reshaping
^^^^^^^^^
Expand Down
0