8000 REF/CLN: ops boilerplate #23853 by makbigc · Pull Request #24846 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

REF/CLN: ops boilerplate #23853 #24846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

REF/CLN: ops boilerplate #23853 #24846

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d60f317
Add CompWrapper to clean code
makbigc Jan 20, 2019
2c09418
Remove commented code
makbigc Jan 20, 2019
0c1a296
Isort the files
makbigc Jan 20, 2019
cb938ce
Move CompWrapper from arrays/base.py to ops.py
makbigc Jan 21, 2019
8966432
Import CompWrapper from its new location
makbigc Jan 26, 2019
99f8afd
Add check for EA instance in _inst_from_senior_cls
makbigc Jan 26, 2019
c17322e
Wrap _cat_compare_op with CompWrapper
makbigc Jan 26, 2019
45e1df0
Wrap the func inside _cat_compare_op
makbigc Jan 26, 2019
72e8b2d
Wrap add and sub methods with CompWrapper
makbigc Jan 26, 2019
b07279f
Remove CompWrapper
makbigc Jan 26, 2019
5cf404c
CompWrapper handles validate_len in add and sub methods
makbigc Jan 26, 2019
96e5148
Change error msg in test_sub_dti_dti
makbigc Jan 27, 2019
f744ccd
Set inst_from_senior_cls as None
makbigc Jan 27, 2019
1234372
Remove lib
makbigc Jan 27, 2019
ef40bcd
Wrap the comp more specifically
makbigc Jan 27, 2019
57463cc
isort ops.py
makbigc Jan 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Isort the files
  • Loading branch information
@makbigc
makbigc committed Jan 27, 2019
commit 0c1a296d69b2281a80537b62adf74897fca3af45
2 changes: 1 addition & 1 deletion pandas/core/arrays/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
This is an experimental API and subject to breaking changes
without warning.
"""
import operator
from functools import wraps
import operator

import numpy as np

Expand Down
5 changes: 2 additions & 3 deletions pandas/core/arrays/datetimes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,12 @@
is_extension_type, is_float_dtype, is_object_dtype, is_period_dtype,
is_string_dtype, is_timedelta64_dtype, pandas_dtype)
from pandas.core.dtypes.dtypes import DatetimeTZDtype
from pandas.core.dtypes.generic import (
ABCIndexClass, ABCPandasArray, ABCSeries)
from pandas.core.dtypes.generic import ABCIndexClass, ABCPandasArray, ABCSeries
from pandas.core.dtypes.missing import isna

from pandas.core import ops
from pandas.core.algorithms import checked_add_with_arr
from pandas.core.arrays import datetimelike as dtl, CompWrapper
from pandas.core.arrays import CompWrapper, datetimelike as dtl
from pandas.core.arrays._ranges import generate_regular_range
import pandas.core.common as com

Expand Down
2 changes: 1 addition & 1 deletion pandas/core/arrays/integer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
from pandas.core.dtypes.missing import isna, notna

from pandas.core import nanops
from pandas.core.arrays import ExtensionArray, ExtensionOpsMixin, CompWrapper
from pandas.core.arrays import CompWrapper, ExtensionArray, ExtensionOpsMixin
from pandas.core.tools.numeric import to_numeric


Expand Down
3 changes: 1 addition & 2 deletions pandas/core/arrays/period.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@
_TD_DTYPE, ensure_object, is_datetime64_dtype, is_float_dtype,
is_period_dtype, pandas_dtype)
from pandas.core.dtypes.dtypes import PeriodDtype
from pandas.core.dtypes.generic import (
ABCIndexClass, ABCPeriodIndex, ABCSeries)
from pandas.core.dtypes.generic import ABCIndexClass, ABCPeriodIndex, ABCSeries
from pandas.core.dtypes.missing import isna, notna

import pandas.core.algorithms as algos
Expand Down
2 changes: 1 addition & 1 deletion pandas/core/arrays/timedeltas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
import pandas.compat as compat
from pandas.util._decorators import Appender

from pandas.core.arrays import CompWrapper
from pandas.core.dtypes.common import (
_NS_DTYPE, _TD_DTYPE, ensure_int64, is_datetime64_dtype, is_dtype_equal,
is_float_dtype, is_integer_dtype, is_list_like, is_object_dtype, is_scalar,
Expand All @@ -28,6 +27,7 @@

from pandas.core import ops
from pandas.core.algorithms import checked_add_with_arr
from pandas.core.arrays import CompWrapper
import pandas.core.common as com

from pandas.tseries.frequencies import to_offset
Expand Down
0