-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
BUG: DataFrame.merge(suffixes=) does not respect None #24819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
82c52a4
one in all
charlesdong1991 dd605e0
change whatsnew to 0.25
charlesdong1991 af7f9ad
add back other comment
charlesdong1991 4d5e1a9
double check test
charlesdong1991 3f65bf1
changes based on discussion
charlesdong1991 ce7e4b8
changes based on discussion with joris
charlesdong1991 90ca9cd
slight change
charlesdong1991 e995a04
slight changes
charlesdong1991 9c3dfbd
changes based on jeff review
charlesdong1991 441e9a5
fix test error
charlesdong1991 71729b2
ci fail, try again
charlesdong1991 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
slight changes
- Loading branch information
commit e995a042d5c9724dbdc2e8a6415a2a3fd2fcd12f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add here a comment like
# TODO reconsider current behaviour of raising, see #....
(with a link to the issue).Just in case later on when we want to change this, we won't think like "oh no, we cannot change it, because it is tested behaviour")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, added!