8000 ENH: Add sort parameter to set operations for some Indexes and adjust… by reidy-p · Pull Request #24521 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

ENH: Add sort parameter to set operations for some Indexes and adjust… #24521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 19, 2019
+389 −226
Merged

ENH: Add sort parameter to set operations for some Indexes and adjust… #24521

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6afbefe
ENH: Add sort parameter to set operations for some Indexes and adjust…
reidy-p Dec 31, 2018
1071f6b
Pass sort parameter into union in join function
reidy-p Dec 31, 2018
fcdd676
Add docstring and change sorting in join function for compatibility
reidy-p Jan 12, 2019
97b0895
Keep default sort=False for intersection in pytables
reidy-p Jan 12, 2019
2edebf1
Index.intersection does not use safe_sort so adjust tests to reflect …
reidy-p Jan 12, 2019
67a4e58
Use safe_sort in Index.intersection
reidy-p Jan 13, 2019
7b15248
Adjust warnings and add TODOs
reidy-p Jan 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Pass sort parameter into union in join function
  • Loading branch information
@reidy-p
reidy-p committed Jan 19, 2019
commit 1071f6bedd0d7ff37b5d70f75a1947e9d19cadf3
2 changes: 1 addition & 1 deletion pandas/core/indexes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3246,7 +3246,7 @@ def join(self, other, how='left', level=None, return_indexers=False,
elif how == 'inner':
join_index = self.intersection(other, sort=sort)
elif how == 'outer':
join_index = self.union(other)
join_index = self.union(other, sort=sort)

if sort:
join_index = join_index.sort_values()
Expand Down
0