8000 implement _index_data parts of #24024 by jbrockmendel · Pull Request #24379 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

implement _index_data parts of #24024 #24379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2018
Merged

implement _index_data parts of #24024 #24379

merged 1 commit into from
Dec 21, 2018

Conversation

jbrockmendel
Copy link
Member

Besides narrowing down the scope of #24024, I think this might fix the segfaults I had in my old DTA branch, which may make it feasible to hugely simplify the composition changeover.

Aside from removing apparently-unused imports in reduction.pyx, the affected code is copied verbatim from #24024.

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@codecov
Copy link
codecov bot commented Dec 21, 2018

Codecov Report

Merging #24379 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24379      +/-   ##
==========================================
+ Coverage   92.29%   92.29%   +<.01%     
==========================================
  Files         162      162              
  Lines       51841    51845       +4     
==========================================
+ Hits        47847    47852       +5     
+ Misses       3994     3993       -1
Flag Coverage Δ
#multiple 90.7% <100%> (ø) ⬆️
#single 42.98% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/period.py 93.11% <100%> (+0.01%) ⬆️
pandas/core/indexes/datetimes.py 96.33% <100%> (ø) ⬆️
pandas/core/indexes/base.py 96.27% <100%> (ø) ⬆️
pandas/core/indexes/timedeltas.py 90.44% <100%> (+0.02%) ⬆️
pandas/util/testing.py 87.66% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d134ec...350b0ec. Read the comment docs.

1 similar comment
@codecov
Copy link
codecov bot commented Dec 21, 2018 •
edited
Loading

Codecov Report

Merging #24379 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24379      +/-   ##
==========================================
+ Coverage   92.29%   92.29%   +<.01%     
==========================================
  Files         162      162              
  Lines       51841    51845       +4     
==========================================
+ Hits        47847    47852       +5     
+ Misses       3994     3993       -1
Flag Coverage Δ
#multiple 90.7% <100%> (ø) ⬆️
#single 42.98% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/period.py 93.11% <100%> (+0.01%) ⬆️
pandas/core/indexes/datetimes.py 96.33% <100%> (ø) ⬆️
pandas/core/indexes/base.py 96.27% <100%> (ø) ⬆️
pandas/core/indexes/timedeltas.py 90.44% <100%> (+0.02%) ⬆️
pandas/util/testing.py 87.66% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d134ec...350b0ec. Read the comment docs.
8000

@jreback jreback added the Internals Related to non-user accessible pandas implementation label Dec 21, 2018
@jreback jreback added this to the 0.24.0 milestone Dec 21, 2018
@jreback jreback merged commit 04a0eac into pandas-dev:master Dec 21, 2018
@jreback
Copy link
Contributor
jreback commented Dec 21, 2018

thanks!

@jbrockmendel jbrockmendel deleted the index_data branch December 21, 2018 14:40
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
implement _index_data parts of pandas-dev#24024 (pandas-dev#24379)
64ec6e1
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
implement _index_data parts of pandas-dev#24024 (pandas-dev#24379)
7d8cd68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @pep8speaks @jreback
0