8000 API: Revert breaking `.values` changes by TomAugspurger · Pull Request #24163 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content
/ pandas Public

API: Revert breaking .values changes #24163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2018
Merged

API: Revert breaking .values changes #24163

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39710e4
API: Revert breaking `.values` changes
TomAugspurger Dec 8, 2018
35310d2
added test for values compat
TomAugspurger Dec 8, 2018
7c22e92
fixed memory usage tests
TomAugspurger Dec 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixed memory usage tests
  • Loading branch information
@TomAugspurger
TomAugspurger committed Dec 8, 2018
commit 7c22e927551faa22dbff3edd40ca5b20f08f8095
5 changes: 4 additions & 1 deletion pandas/core/indexes/datetimes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,10 @@ def memory_usage(self, deep=False):
# TODO: Remove this when we have a DatetimeTZArray
# Necessary to avoid recursion error since DTI._values is a DTI
# for TZ-aware
return self._ndarray_values.nbytes
result = self._ndarray_values.nbytes
# include our engine hashtable
result += self._engine.sizeof(deep=deep)
return result

@cache_readonly
def _is_dates_only(self):
Expand Down
0