8000 Add test for rdivmod on EA array (GH23287) by makbigc · Pull Request #24047 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

Add test for rdivmod on EA array (GH23287) #24047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 20, 2019
Merged

Add test for rdivmod on EA array (GH23287) #24047

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c26b200
Add test for rdivmod on EA array (GH23287)
makbigc Dec 2, 2018
a4c8665
Rename ones as data_for_ones
makbigc Dec 27, 2018
269661d
Change data_for_ones to data_for_twos
makbigc Dec 27, 2018
9fd8b08
Amend after review
makbigc Mar 10, 2019
6d80b58
Add test_divmod_series_array in test_datetime.py
makbigc Mar 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Amend after review
  • Loading branch information
@makbigc
makbigc committed Mar 16, 2019
commit 9fd8b084a3322478e7dbb84e6f9d9a2391fe714f
6 changes: 6 additions & 0 deletions pandas/tests/extension/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ def data():
raise NotImplementedError


@pytest.fixture
def data_for_twos():
"""Length-100 array in which all the elements are two."""
raise NotImplementedError


@pytest.fixture
def data_missing():
"""Length-2 array with [NA, Valid]"""
Expand Down
2 changes: 2 additions & 0 deletions pandas/tests/extension/json/test_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,8 @@ def test_add_series_with_extension_array(self, data):
ser + data

def test_divmod_series_array(self):
# GH 23287
# skipping because it is not implemented
pass

def _check_divmod_op(self, s, op, other, exc=NotImplementedError):
Expand Down
2 changes: 2 additions & 0 deletions pandas/tests/extension/test_categorical.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,8 @@ def test_add_series_with_extension_array(self, data):
ser + data

def test_divmod_series_array(self):
# GH 23287
# skipping because it is not implemented
pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment (skipping because its NotImplemented)


def _check_divmod_op(self, s, op, other, exc=NotImplementedError):
Expand Down
0