-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
CLN: Remove/deprecate unused/misleading dtype functions #23917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
607f853
remove unused maybe_convert_scalar
jbrockmendel 1e95d48
remove unused maybe_convert_string_to_object
jbrockmendel 714c287
remove deprecated is_floating_dtype
jbrockmendel ba6ef3d
deprecate is_period
jbrockmendel a983755
deprecate is_datetimetz
jbrockmendel d7944b6
set stacklevel
jbrockmendel 2c9b406
Merge branch 'master' of https://github.com/pandas-dev/pandas into dt…
jbrockmendel 34c4e91
remove unused is_timedelta_array and is_timedelta64_array
jbrockmendel 8e86599
remove is_int_or_datetime_dtype
jbrockmendel 0cf6239
GH reference
jbrockmendel 8adda17
fixup typecheck
jbrockmendel fe02240
typo fixu[
jbrockmendel 53d1de4
Merge branch 'master' of https://github.com/pandas-dev/pandas into dt…
jbrockmendel e2f8669
8000
Address comments
jbrockmendel 3daaabf
isort
jbrockmendel 2566a18
dummy commit to force CI
jbrockmendel 8342b97
Merge branch 'master' of https://github.com/pandas-dev/pandas into dt…
jbrockmendel a7f7916
Merge branch 'master' of https://github.com/pandas-dev/pandas into dt…
jbrockmendel 6dda1be
separated conditions
jbrockmendel 9c64633
Merge branch 'master' of https://github.com/pandas-dev/pandas into dt…
jbrockmendel 3d8752f
docstring fixup
jbrockmendel bb8a814
Merge branch 'master' of https://github.com/pandas-dev/pandas into dt…
jbrockmendel 71483b5
revert usage of needs_i8_conversion
jbrockmendel e0593bb
dummy commit to force CI
jbrockmendel 5bdc157
Merge branch 'master' of https://github.com/pandas-dev/pandas into dt…
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
remove deprecated is_floating_dtype
- Loading branch information
commit 714c2873443a27a8e411922a4a39efd6ab976ac5
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like a dupe of the line above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing whatsnew makes it look like this has already been removed, but it is still present in master, and not listed (as deprecated or removed) in #6581.
The whatsnew also says is_sequence and is_any_int_dtype have been removed, but each of these are still used in a few places internally. Get rid of those usages? (any_int_dtype only has two usages so that one will be easy)