standardize signatures on Index reductions

pandas-dev · jbrockmendel · Nov 25, 2018 · Nov 25, 2018 · Nov 25, 2018 · Nov 28, 2018
commit febaf6731d01a3a6349d3637c0cc989eeb3c6bd7
diff --git a/pandas/core/base.py b/pandas/core/base.py
@@ -795,7 +795,7 @@ def _ndarray_values(self):
     def empty(self):
         return not self.size
 
-    def max(self):
+    def max(self, skipna=True, axis=None):
         """
         Return the maximum value of the Index.
 
@@ -826,19 +826,21 @@ def max(self):
         >>> idx.max()
         ('b', 2)
         """
+        nv.validate_minmax_axis(axis)
         return nanops.nanmax(self.values)
 
-    def argmax(self, axis=None):
+    def argmax(self, skipna=True, axis=None):
         """
         Return a ndarray of the maximum argument indexer.
 
         See Also
         --------
         numpy.ndarray.argmax
         """
+        nv.validate_minmax_axis(axis)
         return nanops.nanargmax(self.values)
 
-    def min(self):
+    def min(self, skipna=True, axis=None):
         """
         Return the minimum value of the Index.
 
@@ -869,16 +871,18 @@ def min(self):
         >>> idx.min()
         ('a', 1)
         """
+        nv.validate_minmax_axis(axis)
         return nanops.nanmin(self.values)
 
-    def argmin(self, axis=None):
+    def argmin(self, skipna=True, axis=None):
         """
         Return a ndarray of the minimum argument indexer.
 
         See Also
         --------
         numpy.ndarray.argmin
         """
+        nv.validate_minmax_axis(axis)
         return nanops.nanargmin(self.values)
 
     def tolist(self):

diff --git a/pandas/core/indexes/datetimelike.py b/pandas/core/indexes/datetimelike.py
@@ -442,7 +442,7 @@ def tolist(self):
         """
         return list(self.astype(object))
 
-    def min(self, axis=None, *args, **kwargs):
+    def min(self, skipna=True, axis=None, *args, **kwargs):
         """
         Return the minimum value of the Index or minimum along
         an axis.
@@ -470,7 +470,7 @@ def min(self, axis=None, *args, **kwargs):
         except ValueError:
             return self._na_value
 
-    def argmin(self, axis=None, *args, **kwargs):
+    def argmin(self, skipna=True, axis=None, *args, **kwargs):
         """
         Returns the indices of the minimum values along an axis.
 
@@ -493,7 +493,7 @@ def argmin(self, axis=None, *args, **kwargs):
             i8[mask] = np.iinfo('int64').max
         return i8.argmin()
 
-    def max(self, axis=None, *args, **kwargs):
+    def max(self, skipna=True, axis=None, *args, **kwargs):
         """
         Return the maximum value of the Index or maximum along
         an axis.
@@ -521,7 +521,7 @@ def max(self, axis=None, *args, **kwargs):
         except ValueError:
             return self._na_value
 
-    def argmax(self, axis=None, *args, **kwargs):
+    def argmax(self, skipna=True, axis=None, *args, **kwargs):
         """
         Returns the indices of the maximum values along an axis.
 

diff --git a/pandas/core/indexes/range.py b/pandas/core/indexes/range.py
@@ -25,7 +25,6 @@
 
 
 class RangeIndex(Int64Index):
-
     """
     Immutable Index implementing a monotonic integer range.
 
@@ -288,11 +287,11 @@ def _minmax(self, meth):
 
         return self._start + self._step * no_steps
 
-    def min(self):
+    def min(self, skipna=True, axis=None):
         """The minimum value of the RangeIndex"""
         return self._minmax('min')
 
-    def max(self):
+    def max(self, skipna=True, axis=None):
         """The maximum value of the RangeIndex"""
         return self._minmax('max')