-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
Implement mul, floordiv, mod, divmod, and reversed directly in TimedeltaArray #23885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2f75de9
implement floordiv, rfloordiv, mod, rmod, dimod, rdivmod directly in …
jbrockmendel 749cfed
Merge branch 'master' of https://github.com/pandas-dev/pandas into ht…
jbrockmendel 1515e21
Merge branch 'master' of https://github.com/pandas-dev/pandas into ht…
jbrockmendel d7c727c
define __mul__, __rmul__ directly in TimedeltaArray
jbrockmendel 8ae9059
erroy handling
jbrockmendel 2577ee6
Merge branch 'master' of https://github.com/pandas-dev/pandas into ht…
jbrockmendel 62d2018
Merge branch 'master' of https://github.com/pandas-dev/pandas into ht…
jbrockmendel 8f7b7b4
Merge branch 'master' of https://github.com/pandas-dev/pandas into ht…
jbrockmendel 6d162d8
Merge branch 'master' of https://github.com/pandas-dev/pandas into ht…
jbrockmendel ef25750
remove no-longer-necessary
jbrockmendel bc5a3d6
Merge branch 'master' of https://github.com/pandas-dev/pandas into ht…
jbrockmendel 700c5a2
update error message
jbrockmendel d7591b6
remove unused import
jbrockmendel
<
8000
code class="float-right">bdb27ec
Dec 2, 2018
Merge branch 'master' of https://github.com/pandas-dev/pandas into ht…
jbrockmendel 87f36ac
item_from_zerodim
jbrockmendel 987eecd
Merge branch 'master' of https://github.com/pandas-dev/pandas into ht…
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
remove no-longer-necessary
- Loading branch information
commit ef257504bc7d034145501fff2aa30661a684479c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so you don't do this everywhere?
maybe add a function that you call to avoid repeating code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened #23853 for exactly this reason. It merits a dedicated PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, but now you are missing some code here on several of the operators (from_zero_dim), so maybe better to fix now.