8000 REF/TST: Fix remaining DatetimeArray with DateOffset arithmetic ops by jbrockmendel · Pull Request #23789 · pandas-dev/pandas · GitHub
[go: up one dir, main page]

Skip to content

REF/TST: Fix remaining DatetimeArray with DateOffset arithmetic ops #23789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Nov 28, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
986fdbc
unrelated, change _window->libwindow
jbrockmendel Nov 19, 2018
fd75931
revert non-central
jbrockmendel Nov 19, 2018
66c866b
implement remaining methods to fix dateoffset arithmetic with DTA/TDA
jbrockmendel Nov 19, 2018
4dc17e2
xfail dataframe case
jbrockmendel Nov 19, 2018
da3459c
Merge branch 'master' of https://github.com/pandas-dev/pandas into et…
jbrockmendel Nov 20, 2018
348a8b2
Merge branch 'master' of https://github.com/pandas-dev/pandas into et…
jbrockmendel Nov 20, 2018
dd7e873
dont use verify_integrity, push one more level of test into parametrize
jbrockmendel Nov 20, 2018
c8351bc
Merge branch 'master' of https://github.com/pandas-dev/pandas into et…
jbrockmendel Nov 20, 2018
23a25d1
fix broken tests
jbrockmendel Nov 20, 2018
b4ae288
comment clarification
jbrockmendel Nov 22, 2018
d1ebdbf
Merge branch 'master' of https://github.com/pandas-dev/pandas into et…
jbrockmendel Nov 22, 2018
711ee61
dummy commit to force CI
jbrockmendel Nov 22, 2018
9338b5b
Merge branch 'master' of https://github.com/pandas-dev/pandas into et…
jbrockmendel Nov 25, 2018
5fbe9c8
comments about cached and non-cached implementations
jbrockmendel Nov 25, 2018
c7db0e4
Merge branch 'master' of https://github.com/pandas-dev/pandas into et…
jbrockmendel Nov 26, 2018
a4f9733
coverage
jbrockmendel Nov 26, 2018
b50fedf
special casing in freq_infer
jbrockmendel Nov 26, 2018
7e951e4
special casing followup
jbrockmendel Nov 26, 2018
317e1e7
fix simple_new args
jbrockmendel Nov 26, 2018
5de2d42
Merge branch 'master' of https://github.com/pandas-dev/pandas into et…
jbrockmendel Nov 27, 2018
5433a71
privatize
jbrockmendel Nov 27, 2018
dc137f3
Merge branch 'master' of https://github.com/pandas-dev/pandas into et…
jbrockmendel Nov 27, 2018
2c65f3b
more kludges
jbrockmendel Nov 27, 2018
31c5c0b
Merge branch 'master' of https://github.com/pandas-dev/pandas into et…
jbrockmendel Nov 27, 2018
c3d775e
typo fixup
jbrockmendel Nov 27, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
xfail dataframe case
  • Loading branch information
jbrockmendel committed Nov 19, 2018
commit 4dc17e2f0fb0565283bbfc3d1dc7657a1abd7651
2 changes: 1 addition & 1 deletion pandas/_libs/tslibs/timestamps.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ cdef class _Timestamp(datetime):
typ = getattr(other, '_typ', None)

# a Timestamp-DatetimeIndex -> yields a negative TimedeltaIndex
if typ == ('datetimeindex', 'datetimearray'):
if typ in ('datetimeindex', 'datetimearray'):
# timezone comparison is performed in DatetimeIndex._sub_datelike
return -other.__sub__(self)

Expand Down
4 changes: 4 additions & 0 deletions pandas/tests/arithmetic/test_datetime64.py
Original file line number Diff line number Diff line change
Expand Up @@ -1252,6 +1252,10 @@ def test_dt64arr_add_mixed_offset_array(self, box_with_array):
def test_dt64arr_add_sub_offset_ndarray(self, tz_naive_fixture,
box_with_array):
# GH#18849
if box_with_array is pd.DataFrame:
pytest.xfail("FIXME: ValueError with transpose; "
"alignment error without")

tz = tz_naive_fixture
dti = pd.date_range('2017-01-01', periods=2, tz=tz)
dtarr = tm.box_expected(dti, box_with_array)
Expand Down
0