8000 ENH - Index set operation modifications to address issue #23525 by ms7463 · Pull Request #23538 · pandas-dev/pandas · GitHub
[go: up one dir, main page]

Skip to content

ENH - Index set operation modifications to address issue #23525 #23538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 75 commits into from
May 21, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
c2cf269
ENH - first pass at modifying set operations on indexes. Dont ignore …
sds9995 Nov 7, 2018
435e50f
Merge branch 'master' into enh/index_setops
sds9995 Nov 8, 2018
4922fd3
BUG - account for empty index + non-monotonic index, and dont try to …
sds9995 Nov 8, 2018
5e528a1
TST - update existing tests to account for cross type index joins bei…
sds9995 Nov 8, 2018
cdaa5b0
ENH - incompatibility checks and incompatible type unions
sds9995 Nov 9, 2018
40d57ec
TST - update datetime union tets, add tests for inconsistent unions
sds9995 Nov 9, 2018
11fd041
CLN - refactor union -> _union
sds9995 Nov 11, 2018
8f0ace3
TST - add tests for categrorical index, and compatible inconsistent p…
sds9995 Nov 11, 2018
8364c2e
BUG - union -> _union in overriden _union methods
sds9995 Nov 11, 2018
ab329a9
TST - update test_operator raised exception
sds9995 Nov 11, 2018
93486ad
CLN - pep8 line adherence
sds9995 Nov 11, 2018
e435e4c
ENH - reverse polarity of compatibility check and add docstrings
sds9995 Nov 13, 2018
b9787b8
Merge branch 'master' into enh/index_setops
sds9995 Nov 13, 2018
2241b65
TST - add test fixture for index factories and use in test_setops
sds9995 < 8000 relative-time datetime="2018-11-13T04:30:57Z" class="no-wrap">Nov 13, 2018
4daf360
ENH - cast difference result to original dtype to match other index b…
sds9995 Nov 14, 2018
6e5a52b
TST - update interval setop test to account for difference now return…
sds9995 Nov 14, 2018
d344e11
CLN - remove unnecceary code from test
sds9995 Nov 14, 2018
b339bd1
CLN - reorganize some code to make it more readable
sds9995 Nov 14, 2018
85e2db7
CLN - pep8 adherence
sds9995 Nov 29, 2018
cf34960
CLN - pep8 adherence
sds9995 Nov 29, 2018
7150c22
BUG - fix function name
sds9995 Nov 29, 2018
fbb3743
Merge branch 'master' into enh/index_setops
sds9995 Dec 1, 2018
5aa41f6
BUG - fix numeric index compatibility
sds9995 Dec 1, 2018
02d7a3b
BUG - actually fix numeric compatibilty check, with passing index tests
sds9995 Dec 1, 2018
558e182
DOC - initial whatsnew
sds9995 Dec 2, 2018
706f973
ENH - no longer consider category indexes containing different catego…
sds9995 Dec 4, 2018
2ccab59
TST/CLN - no longer need new index_factory fixture and make code more…
sds9995 Dec 4, 2018
c70f1c0
CLN - make code more readable
sds9995 Dec 5, 2018
edb7e9c
CLN - pep8 adherence
sds9995 Dec 5, 2018
84bfbda
Merge branch 'master' into enh/index_setops
sds9995 Dec 5, 2018
aba75fe
DOC - fix whatsnew entry
sds9995 Dec 5, 2018
fc9f138
BUG - chagne object dtype index construction
sds9995 Dec 5, 2018
69cce99
Merge branch 'master' into enh/index_setops
sds9995 Dec 6, 2018
fdfc7d7
CLN/BUG - clean according to failed pandas-dev style checks
sds9995 Dec 6, 2018
42ca70e
CLN - fix imports with isort
sds9995 Dec 7, 2018
5b25645
CLN - refactor tests and remove overriden public union methods
sds9995 Dec 8, 2018
9b1ee7f
Merge branch 'master' into enh/index_setops
sds9995 Dec 8, 2018
fdf9b71
CLN - make code more efficient and cleanup whatsnew
sds9995 Dec 8, 2018
1de3cc8
Merge branch 'master' into enh/index_setops
sds9995 Jan 1, 2019
8ed1093
DOC - fix ipython code block
sds9995 Jan 1, 2019
77ca3a3
DOC - fix whatsnew code blocks again
sds9995 Jan 2, 2019
5921038
CLN - clean up some code, tests and docs
sds9995 Jan 3, 2019
3b94e3b
CLN - reorganize some code and add TODOs
sds9995 Jan 9, 2019
fd4510e
CLN - remove trailing whitespace
ms7463 Jan 14, 2019
345eec1
Merge branch 'master' into enh/index_setops
sds9995 Jan 14, 2019
265a7ee
Merge branch 'enh/index_setops' of https://github.com/ArtinSarraf/pan…
sds9995 Jan 14, 2019
5de3d57
CLN - fix import order
sds9995 Jan 15, 2019
6d82621
CLN - code cleanup, remove unneccesary operations
sds9995 Jan 17, 2019
0af8a24
Merge branch 'master' into enh/index_setops
sds9995 Jan 21, 2019
5a87715
CLN - apply error messages to both statements
sds9995 Jan 21, 2019
a4f9e78
TST - add regex queries
sds9995 Jan 23, 2019
c3c0caa
Merge branch 'master' into enh/index_setops
sds9995 Feb 11, 2019
0bcbdf4
BUG - fix default sort arg
sds9995 Feb 11, 2019
c410625
BUG - remove print
sds9995 Feb 11, 2019
6bb054f
TST/DOC - move to new whatsnew and use local fixture for tests
sds9995 Feb 12, 2019
aea731c
DOC - minor update to get tests to rerun 8000
ms7463 Feb 13, 2019
b5938fc
Merge branch 'master' into enh/index_setops
sds9995 Feb 28, 2019
25452fc
Merge branch 'enh/index_setops' of https://github.com/ArtinSarraf/pan…
sds9995 Feb 28, 2019
0b97a79
Merge branch 'master' into enh/index_setops
ms7463 Mar 1, 2019
bf11c6f
Merge branch 'master' into enh/index_setops
sds9995 Mar 1, 2019
6fd941d
Merge branch 'enh/index_setops' of https://github.com/ArtinSarraf/pan…
sds9995 Mar 1, 2019
32037b5
DOC - fix docstrings and whatsnew
sds9995 Mar 2, 2019
8870006
Merge branch 'master' into enh/index_setops
sds9995 Mar 11, 2019
1d12bc9
DOC - update docstring
sds9995 Mar 11, 2019
92f6707
TST - use tm.assert_index_equal
sds9995 Mar 12, 2019
fbf3242
Merge branch 'master' into enh/index_setops
sds9995 Mar 20, 2019
38d9f74
TST - parametrize union tests
sds9995 Mar 21, 2019
b9e7b18
Merge branch 'master' into enh/index_setops
sds9995 Mar 21, 2019
69aaa93
DOC - add docstring
sds9995 Mar 21, 2019
b57160a
Merge branch 'master' into enh/index_setops
sds9995 Mar 28, 2019
daa1287
Merge branch 'master' into enh/index_setops
sds9995 May 15, 2019
54898c1
CLN/TST - fix super method calls and add error msg
sds9995 May 15, 2019
fa839a9
TST - add Timestamp to regexand fix import sorting
sds9995 May 15, 2019
a36f475
CLN - minor style updates
sds9995 May 16, 2019
b840f49
Merge branch 'master' into enh/index_setops
sds9995 May 21, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CLN - minor style updates
  • Loading branch information
sds9995 committed May 16, 2019
commit a36f475c44a07c36cf94a6fe9dcb0043bc885114
6 changes: 3 additions & 3 deletions
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ def test_union2(self, sort):
union = first.union(second, sort=sort)
tm.assert_index_equal(union, everything)

@pytest.mark.parametrize("klass", [np.array, Series, list])
@pytest.mark.parametrize("box", [np.array, Series, list])
@pytest.mark.parametrize("sort", [None, False])
def test_union3(self, sort, klass):
def test_union3(self, sort, box):
everything = tm.makeDateIndex(10)
first = everything[:5]
second = everything[5:]
Expand All @@ -40,7 +40,7 @@ def test_union3(self, sort, klass):
expected = first.astype('O').union(
pd.Index(second.values, dtype='O')
).astype('O')
case = klass(second.values)
case = box(second.values)
result = first.union(case, sort=sort)
tm.assert_index_equal(result, expected)

Expand Down
4 changes: 2 additions & 2 deletions pandas/tests/indexes/test_setops.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@
@pytest.fixture(params=list(it.combinations(indices_list, 2)),
ids=lambda x: type(x[0]).__name__ + type(x[1]).__name__)
def index_pair(request):
'''
"""
Create all combinations of 2 index types.
'''
"""
return request.param


Expand Down
0