8000 Implement take for EA mixins by jbrockmendel · Pull Request #23159 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

Implement take for EA mixins #23159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Implement take for EA mixins #23159

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
084cb34
implement take for EA mixins
jbrockmendel Oct 15, 2018
0971615
remove unused import
jbrockmendel Oct 15, 2018
a83adad
un-implement copy
jbrockmendel Oct 15, 2018
a16c900
Merge branch 'master' of https://github.com/pandas-dev/pandas into dl…
jbrockmendel Oct 15, 2018
755bc5c
Avoid timezone-loss warning
jbrockmendel Oct 15, 2018
50234e9
Tests for concat_same_type
jbrockmendel Oct 15, 2018
16c361b
Merge branch 'master' of https://github.com/pandas-dev/pandas into dl…
jbrockmendel Oct 15, 2018
dcc985e
use Index.take for Index subclasses
jbrockmendel Oct 15, 2018
a1fea06
troubleshoot
jbrockmendel Oct 16, 2018
23d2724
Merge branch 'master' of https://github.com/pandas-dev/pandas into dl…
jbrockmendel Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unused import
  • Loading branch information
@jbrockmendel
jbrockmendel committed Oct 15, 2018
commit 0971615f4a78a99f7f1e8684b1e97f10dae57b41
1 change: 0 additions & 1 deletion pandas/core/arrays/datetimelike.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
is_object_dtype)
from pandas.core.dtypes.generic import ABCSeries, ABCDataFrame, ABCIndexClass
from pandas.core.dtypes.dtypes import DatetimeTZDtype
from pandas.core.dtypes.missing import isna

import pandas.core.common as com
from pandas.core.algorithms import checked_add_with_arr, take
Expand Down
2 changes: 1 addition & 1 deletion pandas/tests/arrays/test_datetimelike.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ def test_take_fill_valid(self, period_index):
with pytest.raises(ValueError):
# fill_value Period with mis-matched freq invalid
arr.take([0, 1], allow_fill=True,
fill_value=pd.Timestamp.now().to_period(2*pi.freq))
fill_value=pd.Timestamp.now().to_period(2 * pi.freq))

with pytest.raises(ValueError):
# fill_value Timedelta invalid
Expand Down
0