8000 CLN: Move some PI/DTI methods to EA subclasses, implement tests by jbrockmendel · Pull Request #22961 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

CLN: Move some PI/DTI methods to EA subclasses, implement tests #22961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 8, 2018
Merged

CLN: Move some PI/DTI methods to EA subclasses, implement tests #22961

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0a5f343
Move some PeriodIndex/DatetimeIndex methods to EA subclasses, impleme…
jbrockmendel Oct 3, 2018
f1f5146
fixup missing import
jbrockmendel Oct 3, 2018
effef65
Merge branch 'master' of https://github.com/pandas-dev/pandas into dl…
jbrockmendel Oct 3, 2018
4eb5060
Suggested renames
jbrockmendel Oct 3, 2018
09f1b02
Revert change that broke things
jbrockmendel Oct 3, 2018
68116c4
Revert change that broke tests
jbrockmendel Oct 3, 2018
12eb1b9
Fix failing test by ammending constructor
jbrockmendel Oct 3, 2018
ed30d73
flake8 whitespace fixup
jbrockmendel Oct 3, 2018
5b4c828
requested verbosification
jbrockmendel Oct 4, 2018
61808d3
fixup property wrapping
jbrockmendel Oct 4, 2018
927e4bd
Merge branch 'master' of https://github.com/pandas-dev/pandas into dl…
jbrockmendel Oct 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert change that broke things
  • Loading branch information
@jbrockmendel
jbrockmendel committed Oct 3, 2018
commit 09f1b0260b2aaed7d16acc1fdc25dacb45f30ddf
2 changes: 1 addition & 1 deletion pandas/core/arrays/period.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ def to_timestamp(self, freq=None, how='start'):
return self.to_timestamp(how='start') + adjust
else:
adjust = Timedelta(1, 'ns')
return (self + self.freq).to_timestamp(how='start') - adjust
return (self + 1).to_timestamp(how='start') - adjust

if freq is None:
base, mult = frequencies.get_freq_code(self.freq)
Expand Down
0