8000 API: better error-handling for df.set_index by h-vetinari · Pull Request #22486 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

API: better error-handling for df.set_index #22486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 19, 2018
Merged

API: better error-handling for df.set_index #22486

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
28ec3a9
API: better error-handling for df.set_index
h-vetinari Aug 23, 2018
8dd1453
Review (jreback)
h-vetinari Sep 19, 2018
18d3464
Review (jreback)
h-vetinari Sep 23, 2018
fa68660
Allow list-likes (review jreback)
h-vetinari Sep 26, 2018
6d3dfa1
Merge remote-tracking branch 'upstream/master' into df_set_index_warn
h-vetinari Oct 2, 2018
159ecf5
Merge remote-tracking branch 'upstream/master' into df_set_index_warn
h-vetinari Oct 3, 2018
46f8dc7
Merge remote-tracking branch 'upstream/master' into df_set_index_warn
h-vetinari Oct 3, 2018
3a6469d
Review (jreback)
h-vetinari Oct 3, 2018
c3cdde2
Merge remote-tracking branch 'upstream/master' into df_set_index_warn
h-vetinari Oct 5, 2018
dd8d000
Review (jreback)
h-vetinari Oct 5, 2018
47c4e74
Improve comment
h-vetinari Oct 8, 2018
06ed33a
Merge remote-tracking branch 'upstream/master' into df_set_index_warn
h-vetinari Oct 16, 2018
9871be2
Merge remote-tracking branch 'upstream/master' into df_set_index_warn
h-vetinari Oct 18, 2018
9da6e6c
Retrigger Circle
h-vetinari Oct 18, 2018
361a905
Merge remote-tracking branch 'upstream/master' into df_set_index_warn
h-vetinari Oct 18, 2018
42d5f2a
Incorporate allow_sets-kwarg for is_list_like
h-vetinari Oct 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Review (jreback)
  • Loading branch information
@h-vetinari
h-vetinari committed Sep 26, 2018
commit 18d3464e021a5d2613e183bc0c8823c736d03d80
6 changes: 3 additions & 3 deletions pandas/tests/frame/test_alter_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,13 +234,13 @@ def test_set_index_raise(self, frame_of_index_cols, drop, append):
with tm.assert_raises_regex(KeyError, 'X'):
df.set_index([df['A'], df['B'], 'X'], drop=drop, append=append)

rgx = 'The parameter "keys" may only contain a combination of.*'
msg = 'The parameter "keys" may only contain a combination of.*'
# forbidden type, e.g. set
with tm.assert_raises_regex(TypeError, rgx):
with tm.assert_raises_regex(TypeError, msg):
df.set_index(set(df['A']), drop=drop, append=append)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you singling out an iterable (set) is there some reason?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just any of the types that are not allowed (I've tried to indicate as much by using "e.g.")


# forbidden type in list, e.g. set
with tm.assert_raises_regex(TypeError, rgx):
with tm.assert_raises_regex(TypeError, msg):
df.set_index(['A', df['A'], set(df['A'])],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment above, I am not sure a set is specifically excluded.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am proposing to exclude sets (see above). Irrespective of that, I need to test raising the TypeError for forbidden types (which type exactly is less relevant)

drop=drop, append=append)

Expand Down
0