8000 BUG: Series construction sharing data with DTI by makbigc · Pull Request #22113 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

BUG: Series construction sharing data with DTI #22113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

BUG: Series construction sharing data with DTI #22113

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
72b7ee5
Fix Bug #21907
makbigc Jul 29, 2018
260afd8
Update test_constructors.py
makbigc Aug 7, 2018
ca4ff5d
Update v0.24.0.txt
makbigc Aug 7, 2018
f0397ef
Add assertion that expected[0] is not NaT
makbigc Nov 11, 2018
388a21a
Change data to data._values in checking condition
makbigc Nov 18, 2018
aba2368
remove duplicate line in v0.24.0.rst
makbigc Nov 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change data to data._values in checking condition
  • Loading branch information
@makbigc
makbigc committed Nov 18, 2018
commit 388a21a9f652e506c6f505ab99202e94c55c76c4
3 changes: 1 addition & 2 deletions pandas/core/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,8 @@ def __init__(self, data=None, index=None, dtype=None, name=None,
# astype copies
data = data.astype(dtype)
else:
# need to copy to avoid aliasing issues
# GH21907
if isinstance(data, DatetimeIndex):
if isinstance(data._values, DatetimeIndex):
data = data.copy(deep=True)
else:
data = data._values.copy()
Expand Down
0