lint cleanups

pandas-dev · jbrockmendel · Jul 20, 2018 · Jul 12, 2018 · Jul 12, 2018 · Jul 14, 2018
commit 96c0d37e550d826b876bb54e386fab6b57ad150a
diff --git a/.coveragerc b/.coveragerc
@@ -22,11 +22,6 @@ exclude_lines =
     if 0:
     if __name__ == .__main__.:
 
-    # Workaround for cython misreporting def/cpdef/cdef lines
-    # https://github.com/cython/cython/issues/1461
-    ^cdef
-    ^cpdef
-
 ignore_errors = False
 show_missing = True
 

diff --git a/pandas/_libs/tslibs/period.pyx b/pandas/_libs/tslibs/period.pyx
@@ -1591,8 +1591,8 @@ cdef class _Period(object):
         return value
 
     def __setstate__(self, state):
-        self.freq=state[1]
-        self.ordinal=state[2]
+        self.freq = state[1]
+        self.ordinal = state[2]
 
     def __reduce__(self):
         object_state = None, self.freq, self.ordinal

diff --git a/pandas/_libs/tslibs/util.pxd b/pandas/_libs/tslibs/util.pxd
@@ -1,4 +1,4 @@
-from numpy cimport ndarray, NPY_C_CONTIGUOUS, NPY_F_CONTIGUOUS
+from numpy cimport ndarray
 cimport numpy as cnp
 cnp.import_array()
 

diff --git a/setup.py b/setup.py
@@ -434,6 +434,7 @@ def get_tag(self):
 # "linetrace" (with a Truthy value)
 linetrace = os.environ.get('linetrace', False)
 CYTHON_TRACE = str(int(bool(linetrace)))
+# TODO: Maybe make this a CLI option for build_ext?
 
 # Note: if not using `cythonize`, coverage can be enabled by
 # pinning `ext.cython_directives = directives` to each ext in extensions.
@@ -449,6 +450,8 @@ def get_tag(self):
 # ----------------------------------------------------------------------
 # Specification of Dependencies
 
+# TODO: Need to check to see if e.g. `linetrace` has changed and possibly
+# re-compile.
 def maybe_cythonize(extensions, *args, **kwargs):
     """
     Render tempita templates before calling cythonize