8000 Fix categorical from codes nan 21767 by miker985 · Pull Request #21775 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

Fix categorical from codes nan 21767 #21775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 1, 2018
Merged

Fix categorical from codes nan 21767 #21775

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
355ffd7
Add NaN check to Categorical.from_codes
miker985 Jul 6, 2018
acb00db
Add whatsnew entry
miker985 Jul 6, 2018
c625ebb
Use pandas is_integer_dtype
miker985 Jul 6, 2018
93659e8
Warn for float dtype
miker985 Jul 9, 2018
a880024
Address two comments from jreback
miker985 Jul 9, 2018
b6e173b
Address comments from jreback
miker985 Jul 9, 2018
69fb0d5
Address stacklevel request from Tom
miker985 Jul 12, 2018
bab4c76
Address comments from Tom
miker985 Jul 12, 2018
c41bf01
Use "msg" not "err"
miker985 Jul 12, 2018
3d955d1
Add issue reference
miker985 Jul 30, 2018
b8d4b83
Test converted floats are correct int values
miker985 Jul 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address comments from Tom
  • Loading branch information
@miker985
miker985 committed Jul 30, 2018
commit bab4c76d8e4c7e18793a952bf5a60f51ee9eecbc
4 changes: 2 additions & 2 deletions doc/source/whatsnew/v0.24.0.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ Deprecations
- :meth:`MultiIndex.to_hierarchical` is deprecated and will be removed in a future version (:issue:`21613`)
- :meth:`Series.ptp` is deprecated. Use ``numpy.ptp`` instead (:issue:`21614`)
- :meth:`Series.compress` is deprecated. Use ``Series[condition]`` instead (:issue:`18262`)
- :meth:`Categorical.from_codes` has deprecated providing float values for the ``codes`` argument.
- :meth:`Categorical.from_codes` has deprecated providing float values for the ``codes`` argument. (:issue:`21767`)

.. _whatsnew_0240.prior_deprecations:

Expand Down Expand Up @@ -487,7 +487,7 @@ Bug Fixes
Categorical
^^^^^^^^^^^

- Bug in :meth:`Categorical.from_codes` where ``NaN`` values in `codes` were silently converted to ``0`` (:issue:`21767`)
- Bug in :meth:`Categorical.from_codes` where ``NaN`` values in `codes` were silently converted to ``0`` (:issue:`21767`). In the future this will raise a ``ValueError``. Also changes the behavior of `.from_codes([1.1, 2.0])`.

Datetimelike
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a note in deprection section about from_codes accepting floats.

^^^^^^^^^^^^
Expand Down
0