8000 Maintain Dict Ordering with Concat by SaturninoMateus · Pull Request #21512 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

Maintain Dict Ordering with Concat #21512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Maintain Dict Ordering with Concat #21512

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
87bb1ac
Fixes #21510 Remove sort if its already an ordered dict
SaturninoMateus Jun 16, 2018
f9d105e
Adding a space and new line to match PEP8. #21510
SaturninoMateus Jun 16, 2018
b044e04
Adding test case for concat OrderedDict and updating . #21510
SaturninoMateus Jun 17, 2018
eaa7cc0
Fixing v0.23.2.txt syntax . #21510
SaturninoMateus Jun 17, 2018
6869e2c
Improving test case for orderedDict and whatsnew info. #21510
SaturninoMateus Jun 17, 2018
e9561fe
Refactoring test case code for orderedDict and improving whatsnew inf…
SaturninoMateus Jun 19, 2018
53aca81
Fixing spaces to match with PEP8. #21510
SaturninoMateus Jun 19, 2018
726755f
Merging upstream/master into my dev branch
SaturninoMateus Jun 21, 2018
a7aa052
Adding info about pd.concat method into whatsnew 0.24.0 #21510
SaturninoMateus Jun 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load 8000 comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixing v0.23.2.txt syntax . #21510
  • Loading branch information
@SaturninoMateus
SaturninoMateus committed Jun 17, 2018
commit eaa7cc0b688c42aef0c2bba29d0c571ccb6d4b7f
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v0.23.2.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,5 +83,5 @@ Bug Fixes
**Other**

- Bug in :meth:`Series.nlargest` for signed and unsigned integer dtypes when the minimum value is present (:issue:`21426`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you picked up some extra text here. also move to 0.24

- Bug in :class:`_Concatenator` should not sort Ordered Dictionaries (:issue:21510`)
- Bug in :class:`_Concatenator` should not sort Ordered Dictionaries (:issue:`21510`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you come up with some less technical? This is too focused on the technical aspect of the change, but you really should be writing something that a casual user could read and understand in the whatsnew

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I would just say that the bug was causing pd.concat to not respect order present in an ordered dictionary object (something along those lines).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check my last commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting closer but you should remove any reference to _Concatenator as it is a private class. I would be fine with almost a copy/paste of what @gfyoung suggested above as well

-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to go into 0.24.0 as even though its a bug fix, its a jaring one, should be in reshaping.

0