8000 BUG: inconsistency between replace dict using integers and using strings (#20656) by peterpanmj · Pull Request #21477 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

BUG: inconsistency between replace dict using integers and using strings (#20656) #21477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 9, 2018
Merged

BUG: inconsistency between replace dict using integers and using strings (#20656) #21477

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d8f2d70
BUG: align logic between replace dict using integers and using string…
peterpanmj Jun 7, 2018
3afd287
remove unused condition BlockManager
peterpanmj Jul 31, 2018
2bafaaa
add docstring for ObjectBlock._replace_single and BlockManager._maybe…
peterpanmj Jul 31, 2018
f76b2e2
update whatsnew entry ,move to reshaping
peterpanmj Jul 31, 2018
6f836b4
cosmetic changes and doc-string enhancing
peterpanmj Aug 3, 2018
dd916d2
pull and update whatsnew
peterpanmj Aug 3, 2018
7b1624b
Merge branch 'master' into replace_object
peterpanmj Aug 3, 2018
4729fc5
Merge branch 'master' into replace_object
peterpanmj Aug 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unused condition BlockManager
  • Loading branch information
@peterpanmj
peterpanmj committed Jul 31, 2018
commit 3afd287cbbfbe562d87be0c0adfb702213f664b7
5 changes: 1 addition & 4 deletions pandas/core/internals/managers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@
is_datetimelike_v_numeric,
is_numeric_v_string_like, is_extension_type,
is_extension_array_dtype,
is_scalar,
is_re_compilable)
is_scalar)
from pandas.core.dtypes.cast import (
maybe_promote,
infer_dtype_from_scalar,
Expand Down Expand Up @@ -580,8 +579,6 @@ def comp(s, reg=False):
if hasattr(s, 'asm8'):
return _maybe_compare(maybe_convert_objects(values),
getattr(s, 'asm8'), reg)
if reg and is_re_compilable(s):
return _maybe_compare(values, s, reg)
return _maybe_compare(values, s, reg)

masks = [comp(s, regex) for i, s in enumerate(src_list)]
Expand Down
0