-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
BUG: Construct Timestamp with tz correctly near DST border #21407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c5566d5
BUG: Correctly localize Timestamp near DST
mroeschke 5d207ea
fix #19970
mroeschke f4eb827
Add whatsnew and more comments
mroeschke c8dabe1
pep8
mroeschke 795cc39
Use pydatetime_checkexact
mroeschke f171f9f
Merge remote-tracking branch 'upstream/master' into correct_normalize
mroeschke 7e183a8
use astimezone instead of normalize
mroeschke 3dd00d7
Merge remote-tracking branch 'upstream/master' into correct_normalize
mroeschke ae9dc7b
move whatsnew and simplify logic
mroeschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
use astimezone instead of normalize
- Loading branch information
commit 7e183a859a1c84cc52ac1f1d9f40602adf026f6a
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check might be superfluous since
datetimes
natively have theastimezone
method. Then this whole block might be able to be simplified.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, you can try that and see if it works. maybe add a comment anyhow