10000 dispatch Series[datetime64] comparison ops to DatetimeIndex by jbrockmendel · Pull Request #19800 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

dispatch Series[datetime64] comparison ops to DatetimeIndex #19800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 1, 2018
Merged

dispatch Series[datetime64] comparison ops to DatetimeIndex #19800

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
1990e3f
dispatch Series[datetime64] comparison ops to DatetimeIndex
jbrockmendel Feb 20, 2018
f48e6d5
remove unsupported case
jbrockmendel Feb 20, 2018
bd909b0
fix error in older numpys
jbrockmendel Feb 20, 2018
003c4ff
Fixup copy/paste
jbrockmendel Feb 21, 2018
f942be9
unwrap Series to try to debug appveyor breakage
jbrockmendel Feb 21, 2018
59c96e8
port test for None comparison
jbrockmendel Feb 21, 2018
25534c6
troubleshoot appveyor build
jbrockmendel Feb 21, 2018
3d15998
continue troubleshooting Appveyor
jbrockmendel Feb 21, 2018
db487e8
test for date comparison
jbrockmendel Feb 22, 2018
ba290ab
just use isna
jbrockmendel Feb 22, 2018
f8d5bdd
comments
jbrockmendel Feb 24, 2018
9e59598
Merge branch 'master' of https://github.com/pandas-dev/pandas into dt…
jbrockmendel Feb 24, 2018
b618a82
comment
jbrockmendel Feb 24, 2018
35db0a2
Merge branch 'master' of https://github.com/pandas-dev/pandas into dt…
jbrockmendel Feb 25, 2018
3911541
Merge branch 'master' of https://github.com/pandas-dev/pandas into dt…
jbrockmendel Mar 1, 2018
ff51634
Update ops.py
jbrockmendel Mar 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unsupported case
  • Loading branch information
@jbrockmendel
jbrockmendel committed Feb 20, 2018
commit f48e6d52c793dcdf8fb1092d78e7eda94be5c904
4 changes: 2 additions & 2 deletions pandas/tests/indexes/datetimes/test_partial_slicing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import pytest

from datetime import datetime, date
from datetime import datetime
import numpy as np
import pandas as pd
import operator as op
Expand Down Expand Up @@ -349,7 +349,7 @@ def test_loc_datetime_length_one(self):

@pytest.mark.parametrize('datetimelike', [
Timestamp('20130101'), datetime(2013, 1, 1),
date(2013, 1, 1), np.datetime64('2013-01-01T00:00', 'ns')])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remind me, why was this test removed?

Copy link
Member Author
@jbrockmendel jbrockmendel Feb 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b/c ATM Series[datetime64].__cmp__(date) treats the date as a datetime, i.e. allows the comparison. But DatetimeIndex does not -- following convention set by Timestamp (and datetime itself). The DatetimeIndex behavior is canonical.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a separate test for date (I know its wrong, but assert that it is wrong)

np.datetime64('2013-01-01T00:00', 'ns')])
@pytest.mark.parametrize('op,expected', [
(op.lt, [True, False, False, False]),
(op.le, [True, True, False, False]),
Expand Down
0