8000 COMPAT: Emit warning when groupby by a tuple by TomAugspurger · Pull Request #18731 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

COMPAT: Emit warning when groupby by a tuple #18731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 18, 2017
Merged

COMPAT: Emit warning when groupby by a tuple #18731

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
209ffce
COMPAT: Emit warning when groupby by a tuple
TomAugspurger Dec 11, 2017
ad09ade
DOC: avoid future warning
TomAugspurger Dec 11, 2017
a489b20
Merge remote-tracking branch 'upstream/master' into warn-groupby-tuple
TomAugspurger Dec 15, 2017
ade2b2b
Cleanup, test unhashable
TomAugspurger Dec 15, 2017
6050226
PEP8
TomAugspurger Dec 15, 2017
d8c20e8
Correct KeyError
TomAugspurger Dec 15, 2017
d2a2372
update
TomAugspurger Dec 15, 2017
38ef818
xfail
TomAugspurger Dec 15, 2017
a27f449
remove old comments
TomAugspurger Dec 15, 2017
4e5ae9f
pep8
TomAugspurger Dec 15, 2017
a8b4383
Fixups
TomAugspurger Dec 15, 2017
3057aab
Merge remote-tracking branch 'upstream/master' into warn-groupby-tuple
TomAugspurger Dec 18, 2017
File filter

Filter by extension

Filter by extension
8000
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
xfail
  • Loading branch information
@TomAugspurger
TomAugspurger committed Dec 15, 2017
commit 38ef818bc446049fb748cdef64dde222bfd70078
7 changes: 4 additions & 3 deletions pandas/tests/groupby/test_groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2755,13 +2755,14 @@ def test_tuple_warns_unhashable(self):

assert "Interpreting tuple 'by' as a list" in str(w[0].message)

@pytest.mark.xfail(reason="GH-18798")
def test_tuple_correct_keyerror(self):
# https://github.com/pandas-dev/pandas/issues/18798
df = pd.DataFrame(1, index=range(3),
columns=pd.MultiIndex.from_product([[1, 2],
[3, 4]]))
with tm.assert_produces_warning(FutureWarning): # just silence
with tm.assert_raises_regex(KeyError, "(7, 8)"):
df.groupby((7, 8)).mean()
with tm.assert_raises_regex(KeyError, "(7, 8)"):
df.groupby((7, 8)).mean()


def _check_groupby(df, result, keys, field, f=lambda x: x.sum()):
Expand Down
0