8000 BUG: Categorical data fails to load from hdf when all columns are NaN by ssche · Pull Request #18652 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

BUG: Categorical data fails to load from hdf when all columns are NaN #18652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 10, 2017
Merged

BUG: Categorical data fails to load from hdf when all columns are NaN #18652

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3f07908
Fixed #18413, but test case not passing
ssche Dec 5, 2017
7a4f93a
Fixed test case (#18413)
ssche Dec 6, 2017
8540a4a
Removed trailing whitespace
ssche Dec 6, 2017
928c258
Removed unnecessary dataframe copy
ssche Dec 6, 2017
b3766f7
Update whatsnew section
ssche Dec 6, 2017
52dc141
Moved whatsnew entry to 0.21.1
ssche Dec 6, 2017
ea89a7c
Merge branch 'master' into gh18413
ssche Dec 6, 2017
551f0a2
Merge branch 'master' into gh18413
ssche Dec 6, 2017
e6aad40
Addressed requested changes
ssche Dec 8, 2017
7cf7336
Merge branch 'master' into gh18413
ssche Dec 10, 2017
a69ea02
Merge branch 'master' into gh18413
ssche Dec 10, 2017
538e7fe
Merge branch 'master' into PR_TOOL_MERGE_PR_18652
jreback Dec 10, 2017
b2ac7c4
lint fixes
jreback Dec 10, 2017
File filter

Filter by extension

8000 Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
lint fixes
  • Loading branch information
@jreback
jreback committed Dec 10, 2017
commit b2ac7c4d534975eeac49be0ddbfa7e8a3eb89602
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,4 +106,4 @@ doc/build/html/index.html
doc/tmp.sv
doc/source/styled.xlsx
doc/source/templates/
env/
env/
2 changes: 1 addition & 1 deletion pandas/tests/io/test_pytables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4936,7 +4936,7 @@ def test_categorical_nan_only_columns(self):
'a': ['a', 'b', 'c', np.nan],
'b': [np.nan, np.nan, np.nan, np.nan],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add another column with an array like pd.Series([None]* 3, dtype=object). this might fail your test because the original array was an all-null object type (and no float). but let's see.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, seems to work fine.

'c': [1, 2, 3, 4],
'd': pd.Series([None]* 4, dtype=object)
'd': pd.Series([None] * 4, dtype=object)
})
df['a'] = df.a.astype('category')
df['b'] = df.b.astype('category')
Expand Down
0