-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
handle DST appropriately in Timestamp.replace #18618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
cfb760c
handle DST appropriately in Timestamp.replace
jbrockmendel 4ca60fd
better comment, move test to test_timezones
jbrockmendel f738989
informative comment in test
jbrockmendel 98a7296
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 6f36a97
handle DST appropriately in Timestamp.replace
jbrockmendel b916b17
better comment, move test to test_timezones
jbrockmendel b00d763
informative comment in test
jbrockmendel 000f6cd
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel ec9b38a
Merge branch 'replace_bug' of https://github.com/jbrockmendel/pandas …
jbrockmendel f5886e2
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 4cfd949
fix duplicate whatsnews caused by merge mixups
jbrockmendel a3b14f9
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 504cf97
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 4459c9f
fixup merge messup
jbrockmendel 1eb5f2f
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel dced361
refactor test to apply to both pytz and dateutil
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "will no longer crash when handling DST transitions" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crash is a not an appropriate term for user notes.