BUG: Fix to_latex with longtable (#17959) #17960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17960 +/- ##
==========================================
- Coverage 91.6% 91.58% -0.02%
==========================================
Files 153 153
Lines 51306 51306
==========================================
- Hits 46998 46990 -8
- Misses 4308 4316 +8
Continue to review full report at Codecov.
|
|
@syxolk : You just need a |
b3eccbc to
7a71573
Compare
|
I just added the whatsnew entry and squashed the commits. |
gfyoung
approved these changes
Oct 25, 2017
jreback
requested changes
Oct 25, 2017
| @@ -365,7 +365,7 @@ def test_to_latex_longtable(self, frame): | |||
| \midrule | |||
| \endhead | |||
| \midrule | |||
| \multicolumn{3}{r}{{Continued on next page}} \\ | |||
There was a problem hiding this comment.
can you make sure we are testing for 0, 1, 2, 3 columns (you don't have to fully compare the output, just assert that the multicolumn directive is correct)
There was a problem hiding this comment.
Just added test cases for 1 and 3 columns. We already had a test case with 2 columns. I don't think tables with 0 columns make any sense. What do you think?
There was a problem hiding this comment.
sure they do, an empty dataframe is possible
There was a problem hiding this comment.
@jreback : The code has a deliberate short-circuit for an empty DataFrame, and this pattern will not be followed for 0 columns in fact. I added a couple of tests for that short-circuit.
jreback
requested changes
Nov 7, 2017
doc/source/whatsnew/v0.21.0.txt
Outdated
| @@ -998,6 +998,7 @@ I/O | |||
| - Bug in :meth:`DataFrame.to_html` in which there was no validation of the ``justify`` parameter (:issue:`17527`) | |||
| - Bug in :func:`HDFStore.select` when reading a contiguous mixed-data table featuring VLArray (:issue:`17021`) | |||
| - Bug in :func:`to_json` where several conditions (including objects with unprintable symbols, objects with deep recursion, overlong labels) caused segfaults instead of raising the appropriate exception (:issue:`14256`) | |||
| - Bug in :meth:`DataFrame.to_latex` with ``longtable=True`` where a latex multicolumn always spanned over three columns (:issue:`17959`) | |||
|
|
|||
|
can you rebase & update |
|
can you update? |
|
@jreback : I can carry this to the finish line. |
23fc5d3 to
324b780
Compare
Thanks! Sorry, I was quite busy. |
pandas.DataFrame.to_latex(longtable=True) always contained
\multicolumn{3}{r}{{Continued on next page}}
regardless of the number of columns in the output.
677a27d to
9b4d30e
Compare
* Move whatsnew to 0.21.1.txt * Empty tests for empty DataFrame in to_latex
9b4d30e to
930471d
Compare
|
@jreback : All changes have been addressed. PTAL. |
jreback
approved these changes
Dec 11, 2017
TomAugspurger
pushed a commit
to TomAugspurger/pandas
that referenced
this pull request
Dec 11, 2017
closes pandas-dev#17959 (cherry picked from commit e909ea0)
TomAugspurger
pushed a commit
that referenced
this pull request
Dec 12, 2017
gfyoung
added a commit
that referenced
this pull request
Dec 15, 2017
A vestige of gh-17960. Should have been removed before merge.
yarikoptic
added a commit
to neurodebian/pandas
that referenced
this pull request
Feb 22, 2018
Version 0.22.0 * tag 'v0.22.0': (777 commits) RLS: v0.22.0 DOC: Fix min_count docstring (pandas-dev#19005) DOC: More 0.22.0 updates (pandas-dev#19002) TST: Remove pow test in expressions COMPAT: Avoid td.skip decorator DOC: 0.22.0 release docs (pandas-dev#18983) DOC: Include 0.22.0 whatsnew Breaking changes for sum / prod of empty / all-NA (pandas-dev#18921) ENH: Added a min_count keyword to stat funcs (pandas-dev#18876) RLS: v0.21.1 DOC: Add date to whatsnew (pandas-dev#18740) DOC: Include 0.21.1 whatsnew DOC: Update relase notes (pandas-dev#18739) CFG: Ignore W503 DOC: fix options table (pandas-dev#18730) ENH: support non default indexes in writing to Parquet (pandas-dev#18629) BUG: Fix to_latex with longtable (pandas-dev#17959) (pandas-dev#17960) Parquet: Add error message for no engine found (pandas-dev#18717) BUG: Categorical data fails to load from hdf when all columns are NaN (pandas-dev#18652) DOC: clean-up whatsnew file for 0.21.1 (pandas-dev#18690) ...
yarikoptic
added a commit
to neurodebian/pandas
that referenced
this pull request
Feb 22, 2018
* releases: (777 commits) RLS: v0.22.0 DOC: Fix min_count docstring (pandas-dev#19005) DOC: More 0.22.0 updates (pandas-dev#19002) TST: Remove pow test in expressions COMPAT: Avoid td.skip decorator DOC: 0.22.0 release docs (pandas-dev#18983) DOC: Include 0.22.0 whatsnew Breaking changes for sum / prod of empty / all-NA (pandas-dev#18921) ENH: Added a min_count keyword to stat funcs (pandas-dev#18876) RLS: v0.21.1 DOC: Add date to whatsnew (pandas-dev#18740) DOC: Include 0.21.1 whatsnew DOC: Update relase notes (pandas-dev#18739) CFG: Ignore W503 DOC: fix options table (pandas-dev#18730) ENH: support non default indexes in writing to Parquet (pandas-dev#18629) BUG: Fix to_latex with longtable (pandas-dev#17959) (pandas-dev#17960) Parquet: Add error message for no engine found (pandas-dev#18717) BUG: Categorical data fails to load from hdf when all columns are NaN (pandas-dev#18652) DOC: clean-up whatsnew file for 0.21.1 (pandas-dev#18690) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffpandas.DataFrame.to_latex(longtable=True) always contained
\multicolumn{3}{r}{{Continued on next page}}regardless of the number of columns in the output. This is now changed to use the actual number of columns in the output.