8000 CLN: Use pandas.core.common for None checks by jschendel · Pull Request #17816 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

CLN: Use pandas.core.common for None checks #17816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2017
Merged

CLN: Use pandas.core.common for None checks #17816

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e2bdd1
Use pandas.core.common for None checks
jschendel Oct 8, 2017
9599722
add docstrings
jschendel Oct 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add docstrings
  • Loading branch information
@jschendel
jschendel committed Oct 11, 2017
commit 9599722cd7a65671ec0a2278678a32f54aaf1460
6 changes: 6 additions & 0 deletions pandas/core/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,38 +223,44 @@ def _mut_exclusive(**kwargs):


def _not_none(*args):
"""Returns a generator consisting of the arguments that are not None"""
return (arg for arg in args if arg is not None)


def _any_none(*args):
"""Returns a boolean indicating if any argument is None"""
for arg in args:
if arg is None:
return True
return False


def _all_none(*args):
"""Returns a boolean indicating if all arguments are None"""
for arg in args:
if arg is not None:
return False
return True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a 1-liner doc-string to these, otherwise lgtm.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done and green.



def _any_not_none(*args):
"""Returns a boolean indicating if any argument is not None"""
for arg in args:
if arg is not None:
return True
return False


def _all_not_none(*args):
"""Returns a boolean indicating if all arguments are not None"""
for arg in args:
if arg is None:
return False
return True


def _count_not_none(*args):
"""Returns the count of arguments that are not None"""
return sum(x is not None for x in args)


Expand Down
0