8000 ENH: Add skipna parameter to infer_dtype by cpcloud · Pull Request #17066 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

ENH: Add skipna parameter to infer_dtype #17066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 25, 2017
Merged

ENH: Add skipna parameter to infer_dtype #17066

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
62008ec
ENH: Add skipna parameter to infer_dtype
cpcloud Jul 24, 2017
9422651
ENH: Refactor type inference Cython code
cpcloud Jul 24, 2017
68b277b
PERF: No negative index or out of bounds check
cpcloud Jul 24, 2017
b4552c3
DOC: versionadded tag
cpcloud Jul 25, 2017
ddfca51
PERF: Inline leaf classes' methods
cpcloud Jul 25, 2017
234110a
PERF: Don't try to inline the larger methods
cpcloud Jul 25, 2017
ca2e65b
DOC: typo
cpcloud Jul 25, 2017
9a42836
REF: Address comments
cpcloud Jul 25, 2017
1883927
CLN: Simplify is_array_type for strings
cpcloud Jul 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
DOC: versionadded tag
  • Loading branch information
@cpcloud
cpcloud committed Jul 25, 2017
commit b4552c35592b761ded460fd83fa2a8a7c7ce9c20
2 changes: 2 additions & 0 deletions pandas/_libs/src/inference.pyx
View file
8000 Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,8 @@ def infer_dtype(object value, bint skipna=False):
skipna : bool, default False
Ignore NaN values when inferring the type.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versionadded tag

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing: I would prefer that you still mention that we will change the default to True in the future, even if we don't deprecate now. What do you think?


.. versionadded:: 0.21.0

Returns
-------
string describing the common type of the input data.
Expand Down
0