8000 Fixes for #16896(TimedeltaIndex indexing regression for strings) by jdeschenes · Pull Request #16907 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

Fixes for #16896(TimedeltaIndex indexing regression for strings) #16907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 13, 2017
Merged

Fixes for #16896(TimedeltaIndex indexing regression for strings) #16907

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e163de1
Fixes for #16896
Jul 13, 2017
2be2156
Comments from @jreback.
Jul 13, 2017
f65c018
fixed linting issues
Jul 13, 2017
21b5bd2
Changed location of the assert
Jul 13, 2017
dcb274d
Added an extra test
Jul 13, 2017
7d89c19
Added an extra test as per @shoyer recommendation.
Jul 13, 2017
3d36695
Changed assert location
Jul 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed linting issues
  • Loading branch information
Jean-Mathieu Deschenes committed Jul 13, 2017
commit f65c018b5ba2cb27da85bfe374bbc61856e910f3
3 changes: 2 additions & 1 deletion pandas/tests/indexing/test_timedelta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ def test_list_like_indexing(self, indexer, expected):

def test_string_indexing(self):
# GH 16896
df = pd.DataFrame({'x': range(3)}, index=pd.to_timedelta(range(3), unit='days'))
df = pd.DataFrame({'x': range(3)},
index=pd.to_timedelta(range(3), unit='days'))
expected = df.iloc[0]
sliced = df.loc['0 days']
tm.assert_series_equal(sliced, expected)
0