8000 Bug: groupby multiindex levels equals rows by P-Tillmann · Pull Request #16859 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

Bug: groupby multiindex levels equals rows #16859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 24, 2017
Merged

Bug: groupby multiindex levels equals rows #16859

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7928960
BUG: GH16843 fix groupby
P-Tillmann Jul 7, 2017
acd449f
Added whitespaces
P-Tillmann Jul 7, 2017
d5ec754
Added test description
P-Tillmann Jul 11, 2017
f34b10a
Added whats-new
P-Tillmann Jul 11, 2017
cd35777
Merge pull request #1 from pandas-dev/master
Jul 27, 2017
9404a00
removed changes from doc file
P-Tillmann Jul 27, 2017
7980d79
updated whats new file (v0.21.0)
P-Tillmann Jul 27, 2017
2c48282
lint fix
P-Tillmann Jul 27, 2017
9af8a47
replaced inplace=True for set index in testcase, added newline at the…
P-Tillmann Jul 28, 2017
50c7979
Merge branch 'master' into bugfix_groupby_multiindex_levels_equals_rows
gfyoung Aug 21, 2017
a98db9a
DOC: Address reviewer comments
gfyoung Aug 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
BUG: GH16843 fix groupby 
Fix for GH16843 where groubpy gives wrong result when number of
groupedby index+columns is equal to length of axis
  • Loading branch information
@P-Tillmann
P-Tillmann committed Jul 7, 2017
commit 79289601c44b697a0f7b1a0934fdfaace5089799
9 changes: 5 additions & 4 deletions pandas/core/groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2628,13 +2628,14 @@ def _get_grouper(obj, key=None, axis=0, level=None, sort=True,

try:
if isinstance(obj, DataFrame):
all_in_columns = all(g in obj.columns for g in keys)
all_in_columns_index = all(g in obj.columns or g in obj.index.names
for g in keys)
else:
all_in_columns = False
all_in_columns_index = False
except Exception:
all_in_columns = False
all_in_columns_index = False

if not any_callable and not all_in_columns and \
if not any_callable and not all_in_columns_index and \
not any_arraylike and not any_groupers and \
match_axis_length and level is None:
keys = [com._asarray_tuplesafe(keys)]
Expand Down
11 changes: 11 additions & 0 deletions pandas/tests/groupby/test_groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3890,6 +3890,17 @@ def predictions(tool):
expected = df1.groupby('Key').apply(predictions).p1
result = df2.groupby('Key').apply(predictions).p1
tm.assert_series_equal(expected, result)

def test_gb_key_len_equal_axis_len(self):
# GH16843
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a 1-liner about what this is testing

df = pd.DataFrame([['foo','bar', 'B', 1],
['foo','bar', 'B', 2],
['foo','baz', 'C', 3]],
columns=['first','second','third','one'])
df.set_index(['first','second',], inplace=True)
df = df.groupby(['first','second','third']).size()
assert df.loc[('foo','bar','B')]==2
assert df.loc[('foo','baz','C')]==1


def _check_groupby(df, result, keys, field, f=lambda x: x.sum()):
Expand Down
0