MAINT: Drop has_index_names input from read_excel #16522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16522 +/- ##
==========================================
- Coverage 90.78% 90.75% -0.04%
==========================================
Files 161 161
Lines 51089 51086 -3
==========================================
- Hits 46380 46361 -19
- Misses 4709 4725 +16
Continue to review full report at Codecov.
|
c8570aa to
c9069ad
Compare
jreback
reviewed
May 30, 2017
|
|
||
| # We detect headers to determine if index names exist, so | ||
| # that "index" name in the "names" version of the data will | ||
| # now be interpreted as rows that include null data. |
There was a problem hiding this comment.
Yes, because has_index_names got dropped (test fails in original form). That's because when we passed in has_index_names, the value of the parameter would only change to True if they were detected.
d5cbd6e to
638c8f4
Compare
638c8f4 to
f882497
Compare
|
thanks! |
Kiv
pushed a commit
to Kiv/pandas
that referenced
this pull request
Jun 11, 2017
stangirala
pushed a commit
to stangirala/pandas
that referenced
this pull request
Jun 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated since 0.17.0
xref #10967