Validate Timestamp with invalid offset raises ValueError #13116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.14%@@ master #13116 diff @@
==========================================
Files 137 137
Lines 50287 50287
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 42311 42312 +1
+ Misses 7976 7975 -1
Partials 0 0
|
|
@gliptak The test you added is failing (see the travis logs) BTW, you have a large diff, but I don't think you actually changed much? Please only change code that is actually related to the issue, and do not move around other code (difficult to review the diff) |
|
I think #12482 is in a better place to address that issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff