BUG: GH11880 where __contains__ fails in unpacked DataFrame with object cols #12013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7bbbe18 to
98b5d72
Compare
pandas/io/tests/test_packers.py
Outdated
Contributor
There was a problem hiding this comment.
can u do this for zlib as well
Contributor
Author
7440
There was a problem hiding this comment.
zlib is in the standard library
Contributor
There was a problem hiding this comment.
I know, but it doesn't actually have to build with python (e.g if you build it yourself).
Contributor
There was a problem hiding this comment.
not a big deal, really just for consistency (say we add more compressors)
Contributor
|
can you add a simplified version of the test in #11880 (better than the check on the readability of the internals, but if you can't make a better test, use that) |
98b5d72 to
7f044b7
Compare
Contributor
Author
|
updated |
jreback
added a commit
that referenced
this pull request
Jan 15, 2016
BUG: GH11880 where __contains__ fails in unpacked DataFrame with object cols
Contributor
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11880