8000 BLD: sparc test_decimalDecodeTest - {u'a': 4.56} + {u'a': 4.5600000000000005} · Issue #4223 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

BLD: sparc test_decimalDecodeTest - {u'a': 4.56} + {u'a': 4.5600000000000005} #4223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yarikoptic opened this issue Jul 12, 2013 · 9 comments
Closed

BLD: sparc test_decimalDecodeTest - {u'a': 4.56} + {u'a': 4.5600000000000005} #4223

yarikoptic opened this issue Jul 12, 2013 · 9 comments
Milestone
0.12

Comments

@yarikoptic
Copy link
Contributor 
======================================================================
FAIL: test_decimalDecodeTest (pandas.io.tests.test_json.test_ujson.UltraJSONTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/yoh/deb/gits/pkg-exppsy/pandas/debian/tmp/usr/lib/python2.7/dist-packages/pandas/io/tests/test_json/test_ujson.py", line 102, in test_decimalDecodeTest
    self.assertEqual(sut, decoded)
AssertionError: {u'a': 4.56} != {u'a': 4.5600000000000005}
- {u'a': 4.56}
+ {u'a': 4.5600000000000005}

on 0.12.0~rc1+git43-g7b2eaa4-1
@jreback
Copy link
Contributor
jreback commented Jul 12, 2013

cc @Komnomnomnom

@Komnomnomnom
Copy link
Contributor

I'm tempted to remove this test. It's an upstream test that was originally testing for failure when round-trip serialising {u'a': 4.56}, but it turned out the test only passed on 64-bit machines. I modified it to pass on 32-bit but it's fudgy to begin with.

The test after this one verifies that {u'a': 4.56} is properly round-trip serialised when the precise_float flag is passed, IMO that's enough for testing this particular scenario.

Any thoughts on this?

@jreback
Copy link
Contributor
jreback commented Jul 13, 2013

FYI....the sparcs are little-endian which causes some issues in a couple of non-related tests. Does this make a difference?

@jreback jreback mentioned this issue Jul 14, 2013
Closed
@Komnomnomnom
Copy link
Contributor

I'm no expert but I guess it might be what's causing the precision difference. However imo this test is faulty regardless, it is currently known that round-trip serialisation of {u'a': 4.56} will

  • fail on 64-bit arch ==> test PASS
  • succeed on 32-bit arch ==> test PASS after modifications by me
  • fail on 32-bit(?) sparc ==> test FAIL

Given that there's another test which verifies that round-trip serialisation of {u'a': 4.56} will succeed with the precise_float flag turned on and this appears to pass on all platforms I'd argue for removing this test rather than fudging it again to pass on a new architecture.

I'll push the same change / idea up to ultrajson (where perhaps this discussion would be more appropriate) but I just wanted to get a consensus here first.

@jreback
Copy link
Contributor
jreback commented Jul 14, 2013

alright....do a quick PR to remove/skip this test then?

@jreback
Copy link
Contributor
jreback commented Jul 14, 2013

@yarikoptic

actually I think this is still open...hold off a bit on retest

@yarikoptic
Copy link
Contributor Author

no problem -- I can totally do that ;)

On Sun, 14 Jul 2013, jreback wrote:

[1]@yarikoptic

actually I think this is still open...hold off a bit on retest

Yaroslav O. Halchenko, Ph.D.
http://neuro.debian.net http://www.pymvpa.org http://www.fail2ban.org
Senior Research Associate, Psychological and Brain Sciences Dept.
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
Phone: +1 (603) 646-9834 Fax: +1 (603) 646-1419
WWW: http://www.linkedin.com/in/yarik

Komnomnomnom added a commit to Komnomnomnom/pandas that referenced this issue Jul 14, 2013
@Komnomnomnom
TST: remove fudgy ujson test pandas-dev#4223
3f8854e
@Komnomnomnom Komnomnomnom mentioned this issue Jul 14, 2013
Merged
jreback added a commit that referenced this issue Jul 15, 2013
@jreback
Merge pull request #4238 from Komnomnomnom/ujson-fudgy-test
78a6031 
TST: remove fudgy ujson test #4223
@jreback
Copy link
Contributor
jreback commented Jul 15, 2013

@yarikoptic why don't u retest master and let us know
thxs

@jreback
Copy link
Contributor
jreback commented Jul 18, 2013

this was closed by #4223

@jreback jreback closed this as completed Jul 18, 2013
yarikoptic added a commit to neurodebian/pandas that referenced this issue Jul 25, 2013
@yarikoptic
Merge commit 'v0.12.0rc1-79-g50eff60' into debian
0dfc597 
* commit 'v0.12.0rc1-79-g50eff60': (23 commits)
  CLN: replace __repr__ with __unicode__ for string printing (to use StringMixIn)
  BLD: use wheels and newer scipy bc of 33 scipy issue
  TST: force rebuild
  TST: remove fudgy ujson test pandas-dev#4223
  BUG: initialize DatetimeIndex with array of strings (pandas-dev#4229)
  BUG: set name attr in DatetimeIndex and PeriodIndex
  Updated release note about GH4216.
  Check if a plotting DataFrame with kind='kde' has a legend. GH4216
  BUG: Display the legend when calling plot with kind='density'. GH4216
  TST/BUG: disallow bs4==4.2.0 and skip assoc tests
  BLD: test_perf tweaks
  CLN: correct format string
  DOC: release notes
  BUG: raise on invalid colormap for older mpl
  TST: little endian failure, GH4222
  CLN/ENH: clean up docstrings remove some cruft and generalize
  BLD: Turn off the ISRELEASED flag in setup.py
  DOC: minor io.rst edits
  DOC: remove savefig width parameter (pandas-dev#4203)
  BLD: pip 1.4 is coming, preempt issues
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12
Development

No branches or pull requests
3 participants
@yarikoptic @Komnomnomnom @jreback
0