use phar distribution of php-cs-fixer #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
appveyor is failing but on the other side it duplicates travis functionality, it's |
Contributor
Author
|
Or should I invest into fixing the problem? |
d3fa39c to
4061c1c
Compare
Contributor
Author
|
My fault, appveyor is for windows and |
Collaborator
|
I'm going to go ahead and hold out on merging this PR in until we get Symfony 2 working as expected in a feature branch. I added a PHPCS lint to the Travis CI build that will now fail the build if the syntax errors haven't been fixed. |
Another step towards symfony 2.x support. `php-cs-fixer` has dependencies on symfony 3.x . By using phar instead dependencies are not being leaked to the overall library. This PR includes [tm/tooly-composer-script](https://github.com/tommy-muehle/tooly-composer-script) which actually just installs the same phar in the end of the composer command. PS It looks like `composer fix` haven't been run for a while, but I leave it up to maintainers to define/revisit CS rules and CI pipeline for it
4061c1c to
c7d68de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step towards symfony 2.x support.
php-cs-fixerhas dependencies on symfony 3.x . By using phar instead dependencies are not being leaked to the overall library. This PR includes tm/tooly-composer-script which actually just installs the same phar in the end of the composer command.I've also updated composer scripts to use local phpunit and php-cs-fixer instead of global one
PS It looks like
composer fixhaven't been run for a while, but I leave it up to maintainers to define/revisit CS rules and CI pipeline for it