8000 WIP containerized ActivityPub test environment by gabek · Pull Request #4257 · owncast/owncast · GitHub 8000
[go: up one dir, main page]

Skip to content

Conversation

@gabek
Copy link
Member
@gabek gabek commented Mar 21, 2025

@gabek gabek linked an issue Mar 21, 2025 that may be closed by this pull request
@github-actions
Copy link
Contributor
github-actions bot commented Apr 20, 2025 8000

This pull request has not had any activity in 30 days. If it has been abandoned no future actions are necessary, it will be automatically closed. If this is a PR with no clear plan on how to move forward on it getting into the project, then further discussion is needed. Now is a good time to discuss if this is still something that should be worked on. If this PR is idle simply because nobody has reviewed it, then feel free to ping somebody. However, if this PR is not linked to an existing issue regarding something that was previously determined to be important, then even more discussion needs to take place before it can get anywhere. This PR will be closed if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Apr 20, 2025
@gabek gabek added backlog Ideas that might be cool and can be looked into later. and removed stale labels Apr 23, 2025
@gabek gabek requested a review from Copilot April 28, 2025 21:11
Copy link
Contributor
Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a containerized ActivityPub test environment.

  • Adds a docker-compose file for the ActivityPub test server
  • Configures build, environment variables, and volume mounting for the test container
Files not reviewed (2)
  • test/activitypub/Dockerfile: Language not supported
  • test/activitypub/run.sh: Language not supported

environment:
- USERNAME=gabek
volumes:
- ~/.ssh:/root/.ssh: 8000 ro
Copy link
Copilot AI Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mapping the host's SSH directory into the container may unintentionally expose sensitive key files. Consider reviewing this volume mount to ensure it meets the security requirements of the test environment.

Suggested change
- ~/.ssh:/root/.ssh:ro
# 10: - ~/.ssh:/root/.ssh:ro

Copilot uses AI. Check for mistakes.
@gabek gabek force-pushed the develop branch 5 times, most recently from 35099da to 8234974 Compare July 4, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backlog Ideas that might be cool and can be looked into later.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support local federation testing

2 participants

0