fix: [Make] Create windows binaries with .exe extension #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5eeac01
to
fcaebef
Compare
Signed-off-by: Mario Salgado <mariozalgo@gmail.com> Signed-off-by: zalgonoise <mariozalgo@gmail.com>
fcaebef
to
d776aec
Compare
|
Note: the force-push was to add the sign-off mark to the commit, in compliance with the DCO :) |
yesnault
approved these changes
Aug 12, 2024
|
Thank you @zalgonoise |
|
CDS Report build-venom-a#190.0 ✘
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fetching Venom binaries, I noticed that Windows releases didn't include an extension. For Windows, it means that the users will face the program-picker prompt due to a lack of extension, and would have to add it manually.
This PR changes the
CROSS_COMPILED_BINARIESmake target in.build/go.mkto check if the current target OS is windows, and if so, changing the filename to include the.exeextension.I assume that the point of
BINARIESis precisely this, but probably due to some lack of Make syntax knowledge, I couldn't figure out whyIS_WINDOWSisn't being recognized :)That being the case, I am opening a suggestion to leverage the
GOOSenv var taken from theget_os_from_binary_filecall, and changing the filename if the OS iswindows.Any suggestions for changes are welcome, provided that we are able to distribute windows binaries with the proper extension :)