exec: add a 'stdin' attribute #767

cdevienne · 2024-02-19T18:38:11Z

If set, the value is written to the script stdin. This avoid the need to use 'echo' in the script, which makes thing clearer.

It is also particularly useful in the following case (probably other issues with variable substitution):

name: simple_test
vars:
  payload: {"s": "\n"}
testcases:
- name: simple_test
  steps:
  - type: exec
    script: echo {{.payload | toJSON}} | jq .
    assertions:
    - result.code MustEqual 0

This will fail because the \n is not properly escaped.

Using the new stdin attribute solves the issue:

name: simple_test
vars:
  payload: {"s": "\n"}
testcases:
- name: simple_test
  steps:
  - type: exec
    stdin: {{.payload | toJSON}}
    script: jq .
    assertions:
    - result.code MustEqual 0

If set, the value is written to the script stdin. This avoid the need to use 'echo' in the script. Signed-off-by: Christophe de Vienne <christophe.devienne@orus.io>

ovh-cds · 2024-03-28T10:31:13Z

CDS Report build-venom-a#173.0 ✘

Build
- Build ✔
- Unit Tests ✔
Tests
- Acceptance Tests ✘

cdevienne force-pushed the exec-stdin branch from dc26566 to af78d95 Compare February 19, 2024 18:39

exec: add a 'stdin' attribute

9f360ce

If set, the value is written to the script stdin. This avoid the need to use 'echo' in the script. Signed-off-by: Christophe de Vienne <christophe.devienne@orus.io>

cdevienne force-pushed the exec-stdin branch from af78d95 to 9f360ce Compare February 19, 2024 18:46

cdevienne mentioned this pull request Feb 20, 2024

Add a 'command' property to 'exec' #768

Closed

yesnault approved these changes Mar 28, 2024

View reviewed changes

yesnault merged commit 2225450 into ovh:master Mar 28, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

exec: add a 'stdin' attribute #767

exec: add a 'stdin' attribute #767

exec: add a 'stdin' attribute #767

exec: add a 'stdin' attribute #767

Conversation