bug symfony#23330 [WebProfilerBundle] Fix full sized dump hovering in toolbar (ogizanagi)

javiereguiluz · javiereguiluz · commit 7b57b9ed997e · 2017-07-19T19:48:51.000+02:00
This PR was merged into the 2.8 branch. Discussion ---------- [WebProfilerBundle] Fix full sized dump hovering in toolbar | Q | A | ------------- | --- | Branch? | 2.8  | Bug fix? | yes | New feature? | no  | BC breaks? | no | Deprecations? | no  | Tests pass? | yes | Fixed tickets | symfony#23563  | License | MIT | Doc PR | N/A Since symfony#22953, the dump block shown on hovering the toolbar item takes the full width. But at least on OS X chrome, safari and firefox, the behavior is buggy and makes it unusable as the cursor can't reach the dumped content: ![juin-29-2017 21-09-38](https://user-images.githubusercontent.com/2211145/27705877-b25c1496-5d0f-11e7-8fff-169e080e335c.gif) Honestly, I don't really understand the issue here and tried some tweaks until it works everywhere, (including trying to add a `.no-resize` class on `sf-toolbar-info` to avoid executing the related js event listener in case it was conflicting). As shown in the screenshot, it also fixes the case where the dump wasn't full width under a certain size. Commits ------- 28930c5 [WebProfilerBundle] Fix full sized dump hovering in toolbar
diff --git a/Resources/views/Profiler/toolbar.css.twig b/Resources/views/Profiler/toolbar.css.twig
@@ -350,13 +350,12 @@
     100% { background: #222; }
 }
 
-.sf-toolbar-block.sf-toolbar-block-dump {
-    position: static;
-}
-
 .sf-toolbar-block.sf-toolbar-block-dump .sf-toolbar-info {
     max-width: none;
-    right: 0;
+    width: 100%;
+    position: fixed;
+    box-sizing: border-box;
+    left: 0;
 }
 
 .sf-toolbar-block-dump pre.sf-dump {
