management: Fix socket fd leak #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This causes the bugs reported in #60. |
zwass
approved these changes
Aug 6, 2019
Member
There was a problem hiding this comment.
I am good with this, but I wonder whether we should add an explicit close method to the SpawnInstance object. Cursory research indicates using a "destructor" is sketchy in Python.
Given that we are already relying on this implementation-defined behavior I am okay with moving forward using this as a fix.
Member
Author
|
Agree, thus the only expected change people have to make is updating the module version. |
Additionally, bump the version to 3.0.6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this implementation has always leaked a file descriptor. When it was changed to support Windows it started leaking two descriptors on macOS and Linux.
This fixes the bug by closing the descriptor in the deconstructor.