[android] TTS fixes #11757
[android] TTS fixes #11757
Conversation
a6788f8 to
6b4cade
Compare
|
It is said everywhere (docs and stackoverflow) that we have to call |
6b4cade to
adb4816
Compare
There was a problem hiding this comment.
Delaying TTS announcements may lead to road accidents.
Right now they’re either not played at all, or the first announcement gets cut off. Please propose a better solution. |
|
|
Add check for bluetooth sco device. If BleSCO is used we wait 1500 ms before playing sound Updated utterance listener * do not re-request audio focus for each string - we already requested it at start * abandon audio focus only after all strings are played Added logs Updated play logic to reset old request: * Each time we ask TTS to play strings (on speak() or on playTurnNotifications()) we flush the buffer * The first string in the queue flushes the buffer * Other strings are added to the buffer Signed-off-by: Andrei Shkrob <github@shkrob.dev>
adb4816 to
7f75acc
Compare
|
Updated PR - removed 1500ms delay for bluetooth connection |
|
|
||
| protected void onAudioFocusChange(int focusChange) | ||
| { | ||
| Logger.w(TAG, "Unexpected audio focus change: " + focusChange); |
| if (isBluetoothScoDeviceUsed()) | ||
| { | ||
| Logger.d(TAG, "Bluetooth SCO device is used for audio output"); | ||
| mAudioManager.setMode(AudioManager.MODE_IN_COMMUNICATION); |
There was a problem hiding this comment.
What if active device changes after requestAudioFocus() was called? Does it make sense to monitor changes and use the related setMode if a new device is SCO/not SCO? https://developer.android.com/develop/connectivity/bluetooth/ble-audio/audio-manager#java
Add check for bluetooth sco device.
If BleSCO is used we wait 1500 ms before playing sound Updated utterance listener
Added logs
Updated play logic to reset old request:
Should be beta tested especially with bluetooth devices
Related issues:
#11429
#11339
#5176
#5661
#11369
#5109
Some of them may already be resolved by my other TTS fixes