E526 [ios] Edit in-place bookmark name by kirylkaveryn · Pull Request #11475 · organicmaps/organicmaps · GitHub
[go: up one dir, main page]
Skip to content

[ios] Edit in-place bookmark name #11475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[ios] Edit in-place bookmark name #11475

wants to merge 4 commits into from
+437 −368

Conversation

@kirylkaveryn
Copy link
Contributor
@kirylkaveryn kirylkaveryn commented Oct 3, 2025 •
edited
Loading

Closes iOS part of #10657

Tested on

  • iPhone 16e ios18.5 sim
  • iPhone 8 ios15.5 sim
  • iPhone 15pro 18.5 device
  • macOS

image image

image
Simulator.Screen.Recording.-.iPhone.16e.-.2025-10-03.at.18.22.38.mov
Simulator.Screen.Recording.-.iPhone.16e.-.2025-10-03.at.18.21.54.mov
Simulator.Screen.Recording.-.iPhone.16e.-.2025-10-03.at.18.51.35.mov

@kirylkaveryn kirylkaveryn requested a review from a team as a code owner October 3, 2025 17:12
github-actions[bot]
github-actions bot reviewed Oct 3, 2025
View reviewed changes
@kirylkaveryn kirylkaveryn force-pushed the ios/kk-edit-bookmark-name branch from 4019fd7 to 20d3fb8 Compare October 3, 2025 17:16
@kirylkaveryn kirylkaveryn added iOS iOS development UX User eXperience, an issue with usability UI User interface issues labels Oct 3, 2025
@biodranik biodranik added the Beta PRs ready to be tested before merging them to master, or issues found in beta versions. label Oct 4, 2025
biodranik
biodranik reviewed Oct 4, 2025
View reviewed changes
Copy link
Member
@biodranik 8000 biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Does "cancel" really cancels any edits before exiting the editor?
  2. Is pressing "Done" the only way to save the edited title? What if user tapped on the map?
  3. Let's beta test it.

@kirylkaveryn
Copy link
Contributor Author
kirylkaveryn commented Oct 6, 2025
  1. Does "cancel" really cancels any edits before exiting the editor?

Yes. The cancel button reassigns the initial title to the PP header and closes the screen without updating the core

  1. Is pressing "Done" the only way to save the edited title? What if user tapped on the map?

No, not the only. If the user selects another POI, the edition will be saved (if it is not empty)

@biodranik
Copy link
Member
biodranik commented Oct 21, 2025

There are some issues (ios 15), postponing for the today's beta:

telegram-cloud-photo-size-2-5454384127349487371-w
telegram-cloud-photo-size-2-5454384127349487374-w

@biodranik biodranik removed the Beta PRs ready to be tested before merging them to master, or issues found in beta versions. label Oct 21, 2025 8000
@biodranik biodranik mentioned this pull request Nov 1, 2025
Open
@kirylkaveryn
Copy link
Contributor Author
kirylkaveryn commented Nov 4, 2025 •
edited
Loading

There are some issues (ios 15), postponing for the today's beta:

What is the exact ios version?
I've tested on the ios 15.2 and 15.5 (plus 12.5) and cannot reproduce the issue. Please share more info+screenrecording!

iOS 15.2:
Simulator Screen Recording - iPhone SE (1st generation) - 2025-11-04 at 20 40 51

@kirylkaveryn kirylkaveryn force-pushed the ios/kk-edit-bookmark-name branch from 20d3fb8 to 4e4ee99 Compare November 5, 2025 14:00
@kirylkaveryn
Copy link
Contributor Author
kirylkaveryn commented Nov 5, 2025

The pencil icon size was slightly reduced:
image

@biodranik biodranik added the Beta PRs ready to be tested before merging them to master, or issues found in beta versions. label Nov 8, 2025
@kirylkaveryn kirylkaveryn force-pushed the ios/kk-edit-bookmark-name branch 2 times, most recently from ae771bd to d005eb7 Compare November 13, 2025 11:23
@kirylkaveryn kirylkaveryn force-pushed the ios/kk-edit-bookmark-name branch from d005eb7 to 03b6bbd Compare November 20, 2025 14:20
biodranik
biodranik approved these changes Nov 20, 2025
View reviewed changes
Copy link
Member
@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, one issue is that the pen icon disappears when blue "Enter" key on the keyboard is pressed. There are a few more, but they're not critical.

@kirylkaveryn kirylkaveryn force-pushed the ios/kk-edit-bookmark-name branch from 03b6bbd to 74b6334 Compare November 21, 2025 15:36
@biodranik
Copy link
Member
biodranik commented Nov 23, 2025

@kirylkaveryn please fix the long-tap behavior on the name: it should copy the name into the clipboard (and show a short toast that the name has been copied, like a long-tap on the address).

We also need to separately enable long tap (if it's not enabled yet) in other relevant places.

@kirylkaveryn kirylkaveryn force-pushed the ios/kk-edit-bookmark-name branch from 74b6334 to 304f960 Compare November 24, 2025 11:50
@kirylkaveryn
Copy link
Contributor Author
kirylkaveryn commented Nov 24, 2025

Thanks! LGTM, one issue is that the pen icon disappears when blue "Enter" key on the keyboard is pressed. There are a few more, but they're not critical.

Thanks for testing! Fixed:

Simulator.Screen.Recording.-.iPhone.16e.-.2025-11-24.at.12.51.09.mov

@kirylkaveryn please fix the long-tap behavior on the name: it should copy the name into the clipboard (and show a short toast that the name has been copied, like a long-tap on the address).

We also need to separately enable long tap (if it's not enabled yet) in other relevant places.

The long taps are added to the title and address labels.

@kirylkaveryn
[ios] Fix keyboard notification
a4a0e5b 
The keyboard should send the target height before appearance instead of unuseful 0

Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>

# Conflicts:
#	iphone/Maps/UI/Storyboard/Main.storyboard

# Conflicts:
#	iphone/Maps/UI/Storyboard/Main.storyboard
@kirylkaveryn
[ios] In-place bookmark title editing
8cbcc14 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
@kirylkaveryn
[ios] Fix PP editing animation and background shadow
fdaaa10 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
@kirylkaveryn
[ios] Long press copies title/address from the Place page header
af52908 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
@kirylkaveryn kirylkaveryn force-pushed the ios/kk-edit-bookmark-name branch from 304f960 to af52908 Compare November 24, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@biodranik biodranik biodranik approved these changes

Assignees

No one assigned

Labels

Beta PRs ready to be tested before merging them to master, or issues found in beta versions. iOS iOS development UI User interface issues UX User eXperience, an issue with usability

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kirylkaveryn @biodranik
0