Added new unit test for OWLS-87553 and modified existing managed server startup unit tests #2213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er startup unit tests.
russgold
reviewed
Feb 22, 2021
| @@ -156,34 +171,44 @@ private static V1ObjectMeta withNames(V1ObjectMeta objectMeta, String serverName | |||
| .putLabelsItem(SERVERNAME_LABEL, serverName); | |||
| } | |||
|
|
|||
| protected TestUtils.ConsoleHandlerMemento configureOperatorLogger() { | |||
There was a problem hiding this comment.
I can understand a desire to avoid line breaks, but in this case, I think it is clearer to leave this call to silenceOperatorLogger inline, with ignoringLoggedExceptions on the next line.
There was a problem hiding this comment.
Thanks for the review comment, I have made the change as per your suggestion.
russgold
reviewed
Feb 22, 2021
| private void setPodScheduled(String serverName) { | ||
| Objects.requireNonNull(domainPresenceInfo.getServerPod(serverName).getSpec()).setNodeName("aNode"); | ||
| // Marks the specified pod as having been scheduled on a Kubernetes node. | ||
| private void setPodScheduled(V1Pod pod) { |
russgold
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backlog - Added a new unit test for OWLS-87553 fix and modified existing managed server startup tests to invoke WaitForReady step that performs periodic backstop checking in cases where watch event notifications are not delivered reliably.