8000 fix(native-image): macOS source-level debugging by emberian · Pull Request #12796 · oracle/graal · GitHub
[go: up one dir, main page]
Skip to content

fix(native-image): macOS source-level debugging #12796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
emberian wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(native-image): macOS source-level debugging #12796

emberian wants to merge 4 commits into from
+1,463 −104

Conversation

@emberian
Copy link
@emberian emberian commented Jan 13, 2026

tested a few scenarios on my local lldb. seems working :)

mach-O is just a little bit different than ELF dwarf, with its "dsym" bundles. now dwarfdump is warning-free and lldb can break on lines and display source.

image

@oracle-contributor-agreement
Copy link
oracle-contributor-agreement bot commented Jan 13, 2026

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Jan 13, 2026
@emberian
Copy link
Author
emberian commented Jan 13, 2026

Account creation flow is currently tossing 403 when I try and create an Oracle account.

@emberian @claude
refactor: clean up macOS debug info file indexing
a26ed8c 
Address code review feedback:
- Extract isClassFile() helper method in ClassEntry to eliminate
  duplicated file matching logic between ClassEntry and DwarfLineSectionImpl
- Handle edge case where class fileEntry is null or empty
- Document the invariant that class file is always at position 0 in files list
- Remove commented debug code from NativeImageDebugInfoStripFeature
- Improve documentation for hardcoded 0x100004000 text address with TODO

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@zakkak
Copy link
Collaborator
zakkak commented Jan 13, 2026

This PR is related to (fixes?) #4599

@oubidar-Abderrahim oubidar-Abderrahim self-assigned this Jan 19, 2026
@emberian
Copy link
Author
emberian commented Jan 23, 2026

Account creation is unbusted, OCA signed.

@oracle-contributor-agreement
Copy link
oracle-contributor-agreement bot commented Jan 27, 2026

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adinn adinn Awaiting requested review from adinn

@fniephaus fniephaus Awaiting requested review from fniephaus

At least 1 approving review is required to merge this pull request.

Assignees

@oubidar-Abderrahim oubidar-Abderrahim

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emberian @zakkak @oubidar-Abderrahim
0