8000 Pin the version of PyQt6-Qt6 by not522 · Pull Request #5135 · optuna/optuna · GitHub
[go: up one dir, main page]

Skip to content

Pin the version of PyQt6-Qt6 #5135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Pin the version of PyQt6-Qt6 #5135

merged 1 commit into from
Dec 5, 2023

Conversation

not522
Copy link
Member
@not522 not522 commented Dec 1, 2023

Motivation

The windows-tests CI has been failed because of the PyQt6-Qt6 v6.6.1 release. (The same problem was reported in matplotlib. matplotlib/matplotlib#27412)

Description of the changes

  • Pin the version of PyQt6-Qt6 below 6.6.1

@not522 not522 added the CI Continuous integration. label Dec 1, 2023
@not522
Copy link
Member Author
not522 commented Dec 1, 2023

@gen740 Could you review this PR? I think one approval is enough for merge because it is a minor change to the CI.

Copy link
codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9fcd5b9) 89.30% compared to head (12e0c50) 89.43%.
Report is 53 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5135      +/-   ##
==========================================
+ Coverage   89.30%   89.43%   +0.13%     
==========================================
  Files         205      205              
  Lines       15188    15140      -48     
==========================================
- Hits        13564    13541      -23     
+ Misses       1624     1599      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member
@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let me merge this PR since it's clear that this PR has fixed the Windows CI, and it will also resolve CI errors in #5133.

@c-bata c-bata added this to the v3.5.0 milestone Dec 5, 2023
@c-bata c-bata merged commit f1754e8 into optuna:master Dec 5, 2023
@not522 not522 deleted the fix-pyqt6-qt6 branch December 5, 2023 03:36
@gen740 gen740 removed their assignment Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0