Pin mypy version to 1.6.* #5123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5123 +/- ##
=======================================
Coverage 89.32% 89.32%
=======================================
Files 205 205
Lines 15188 15188
=======================================
Hits 13566 13566
Misses 1622 1622 ☔ View full report in Codecov by Sentry. |
4c4a3df to
bbd6192
Compare
|
@HideakiImamura I resolved the conflict and revised the comment a little. Please take anther look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Temporary fix
Checks(integration)by adding version specification onmypyDescription of the changes
It appears that
mypy v1.7.0is causing significant regressions when used in 8000 conjunction withpybind11, upon which mypy's type inference for torch modules depends. This issue is highlighted in python/mypy#16486.This pull request addresses the problem by setting the
mypyversion tov1.6.*until the associated bugs are resolved, asPytorchdoes here.Alternatives
Add
type:ignores and wait for thewarn-unused-ignoresoption to detect that the bug has been resolved.