8000 [FSSDK-9509] Update http_project_config_manager.rb with soft log warning about polling interval < 30s by Mat001 · Pull Request #338 · optimizely/ruby-sdk · GitHub
[go: up one dir, main page]
Skip to content

[FSSDK-9509] Update http_project_config_manager.rb with soft log warning about polling interval < 30s #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 25, 2023
Merged

[FSSDK-9509] Update http_project_config_manager.rb with soft log warning about polling interval < 30s #338

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
49bdc1c
Update http_project_config_manager.rb
Mat001 Sep 25, 2023
53fffd0
Update w single quotes
Mat001 Sep 25, 2023
703b19f
Update http_project_config_manager.rb
Mat001 Sep 25, 2023
cd2228d
Update WARNING to WARN
Mat001 Sep 25, 2023
7975e9d
Update lib/optimizely/config_manager/http_project_config_manager.rb
Mat001 Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
< 8000 h5 data-view-component="true" class="mb-2"> Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/optimizely/config_manager/http_project_config_manager.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,13 @@ def polling_interval(polling_interval)
return
end

if polling_interval < 30
@logger.log(
Logger::WARN,
'Polling intervals below 30 seconds are not recommended.'
)
end

@polling_interval = polling_interval
end

Expand Down
0