8000 [FSSDK-9106] chore: prepare for 5.0.0-beta by andrewleap-optimizely · Pull Request #336 · optimizely/ruby-sdk · GitHub
[go: up one dir, main page]
Skip to content

[FSSDK-9106] chore: prepare for 5.0.0-beta #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 28, 2023
Merged

[FSSDK-9106] chore: prepare for 5.0.0-beta #336

merged 5 commits into from
Apr 28, 2023

Conversation

andrewleap-optimizely
Copy link
Contributor

Summary

  • Prepare for advanced audience targeting release

Issues

FSSDK-9106

@andrewleap-optimizely andrewleap-optimizely marked this pull request as ready for review April 27, 2023 22:39
@andrewleap-optimizely andrewleap-optimizely requested a review from a team as a code owner April 27, 2023 22:39
Mat001
Mat001 requested changes Apr 27, 2023
View reviewed changes
Copy link
Contributor
@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check w Jae about the number of PRs?

Mat001
Mat001 approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor
@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correcting to "approve" status. Just check that Jae is ok with the number of PRs.

russell-loube-optimizely
russell-loube-optimizely reviewed Apr 27, 2023
View reviewed changes
Copy link
@russell-loube-optimizely russell-loube-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@andrewleap-optimizely
Copy link
Contributor Author

Correcting to "approve" status. Just check that Jae is ok with the number of PRs.

I removed a bunch

jaeopt
jaeopt approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor
@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewleap-optimizely andrewleap-optimizely merged commit 267d9dd into master Apr 28, 2023
@andrewleap-optimizely andrewleap-optimizely deleted the aleap/prepare_for_5.0.0-beta branch April 28, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russell-loube-optimizely russell-loube-optimizely russell-loube-optimizely left review comments

@Mat001 Mat001 Mat001 approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees

@andrewleap-optimizely andrewleap-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewleap-optimizely @Mat001 @jaeopt @russell-loube-optimizely
0