8000 feat: add odp segment manager by andrewleap-optimizely · Pull Request #310 · optimizely/ruby-sdk · GitHub
[go: up one dir, main page]
Skip to content

feat: add odp segment manager #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 19, 2022
Merged

feat: add odp segment manager #310

merged 5 commits into from
Aug 19, 2022

Conversation

andrewleap-optimizely
Copy link
Contributor

Summary

Adds OdpSegmentManager to provide internal services for fetching segments from the ODP server.

  • Provides an internal api for fetching segments with given { api_key, api_host, customer key, customer value, segments subset, and options }.
  • Manages a LRU cache for fetched segments (size and timeout are configurable).
  • On segment fetch request, looks up the cache for the user key first. On cache hit (or timeout not expired) it returns the cached segments. Otherwise, it sends a fetch request to the ODP server and caches the result.
  • Supports options for cache lookup (IGNORE_CACHE, RESET_CACHE).

Test plan

  • Added odp_segment_manager_spec.rb

Ticket

OASIS-8446

@andrewleap-optimizely andrewleap-optimizely marked this pull request as ready for review August 16, 2022 17:54
@andrewleap-optimizely andrewleap-optimizely requested a review from a team as a code owner August 16, 2022 17:54
zashraf1985
zashraf1985 suggested changes Aug 17, 2022
View reviewed changes
Copy link
Contributor
@zashraf1985 zashraf1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great! Suggested a few changes.

jaeopt
jaeopt requested changes Aug 17, 2022
View reviewed changes
Copy link
Contributor
@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few small changes suggested.
Some ruby contexts I cannot cover :)

lib/optimizely/odp/odp_config.rb Outdated
@api_key = api_key
@api_host = api_host
@segments_to_check = segments_to_check
@odp_enabled = !api_key.nil? && !api_host.nil? ? true : false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have a similar flag (odpEnabled) in the OdpManager level, which disable all ODP functions including segments and events. This may be conflict with that. We can clean it up here and visit again at the top level.

jaeopt
jaeopt approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor
@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zashraf1985
zashraf1985 approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor
@zashraf1985 zashraf1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!

@andrewleap-optimizely andrewleap-optimizely merged commit cfc1efa into master Aug 19, 2022
@andrewleap-optimizely andrewleap-optimizely deleted the aleap/add_odp_segment_manager branch August 19, 2022 13:08
@andrewleap-optimizely andrewleap-optimizely mentioned this pull request Aug 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zashraf1985 zashraf1985 zashraf1985 approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees

@andrewleap-optimizely andrewleap-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewleap-optimizely @zashraf1985 @jaeopt
0