8000 feat: odp datafile parsing and audience evaluation by andrewleap-optimizely · Pull Request #303 · optimizely/ruby-sdk · GitHub
[go: up one dir, main page]
Skip to content

feat: odp datafile parsing and audience evaluation #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 25, 2022
Merged

feat: odp datafile parsing and audience evaluation #303

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
03a5aff
switch user attributes to user context
andrewleap-optimizely Jul 19, 2022
361bda0
add integrations
andrewleap-optimizely Jul 21, 2022
3e7df79
add qualified segments
andrewleap-optimizely Jul 21, 2022
6a9ed9e
cleanup formatting
andrewleap-optimizely Jul 21, 2022
b50b13c
change CustomAttributeCondEval to UserCondEval
andrewleap-optimizely Jul 22, 2022
64a661a
change user to user_context
andrewleap-optimizely Jul 22, 2022
6e62d50
add test for integrations with arbitrary fields
andrewleap-optimizely Jul 22, 2022
a788f9d
Merge branch 'master' into aleap/odp_datafile_parsing
andrewleap-optimizely Jul 22, 2022
69d1f15
Merge branch 'master' into aleap/odp_datafile_parsing
andrewleap-optimizely Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup formatting
  • Loading branch information
@andrewleap-optimizely
andrewleap-optimizely committed Jul 21, 2022
commit 6a9ed9e4d3a1ead5ede3ab28a325573b5c9a1c9f
28 changes: 14 additions & 14 deletions spec/audience_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
end

it 'should pass conditions when audience conditions exist else audienceIds are passed' do
user_context.instance_variable_set(:@user_attributes, {'test_attribute' => 'test_value_1'})
user_context.instance_variable_set(:@user_attributes, 'test_attribute' => 'test_value_1')
experiment = config.experiment_key_map['test_experiment']
experiment['audienceIds'] = ['11154']
allow(Optimizely::ConditionTreeEvaluator).to receive(:evaluate)
Expand Down Expand Up @@ -99,18 +99,18 @@
user_meets_audience_conditions, reasons = Optimizely::Audience.user_meets_audience_conditions?(config, experiment, user_context, spy_logger)
expect(user_meets_audience_conditions).to be false
expect(reasons).to eq([
"Starting to evaluate audience '11154' with conditions: [\"and\", [\"or\", [\"or\", {\"name\": \"browser_type\", \"type\": \"custom_attribute\", \"value\": \"firefox\"}]]].",
"Audience '11154' evaluated to UNKNOWN.",
"Audiences for experiment 'test_experiment_with_audience' collectively evaluated to FALSE."
])
"Starting to evaluate audience '11154' with conditions: [\"and\", [\"or\", [\"or\", {\"name\": \"browser_type\", \"type\": \"custom_attribute\", \"value\": \"firefox\"}]]].",
"Audience '11154' evaluated to UNKNOWN.",
"Audiences for experiment 'test_experiment_with_audience' collectively evaluated to FALSE."
])

# asserts nil attributes default to empty dict
expect(Optimizely::CustomAttributeConditionEvaluator).to have_received(:new).with(user_context, spy_logger).once
end

it 'should return true for user_meets_audience_conditions? when condition tree evaluator returns true' do
experiment = config.experiment_key_map['test_experiment']
user_context.instance_variable_set(:@user_attributes, {'test_attribute' => 'test_value_1'})
user_context.instance_variable_set(:@user_attributes, 'test_attribute' => 'test_value_1')

allow(Optimizely::ConditionTreeEvaluator).to receive(:evaluate).and_return(true)
user_meets_audience_conditions, reasons = Optimizely::Audience.user_meets_audience_conditions?(config, experiment, user_context, spy_logger)
Expand All @@ -122,7 +122,7 @@

it 'should return false for user_meets_audience_conditions? when condition tree evaluator returns false or nil' do
experiment = config.experiment_key_map['test_experiment_with_audience']
user_context.instance_variable_set(:@user_attributes, {'browser_type' => 'firefox'})
user_context.instance_variable_set(:@user_attributes, 'browser_type' => 'firefox')

# condition tree evaluator returns nil
allow(Optimizely::ConditionTreeEvaluator).to receive(:evaluate).and_return(nil)
Expand All @@ -144,7 +144,7 @@

it 'should correctly evaluate audience Ids and call custom attribute evaluator for leaf nodes' do
experiment = config.experiment_key_map['test_experiment_with_audience']
user_context.instance_variable_set(:@user_attributes, {'browser_type' => 'firefox'})
user_context.instance_variable_set(:@user_attributes, 'browser_type' => 'firefox')
experiment['audienceIds'] = %w[11154 11155]
experiment['audienceConditions'] = nil

Expand All @@ -163,7 +163,7 @@
end

it 'should correctly evaluate audienceConditions and call custom attribute evaluator for leaf nodes' do
user_context.instance_variable_set(:@user_attributes, {'house' => 'Gryffindor', 'lasers' => 45.5})
user_context.instance_variable_set(:@user_attributes, 'house' => 'Gryffindor', 'lasers' => 45.5)
experiment = typed_audience_config.get_experiment_from_key('audience_combinations_experiment')
experiment['audienceIds'] = []
experiment['audienceConditions'] = ['or', %w[or 3468206642 3988293898], %w[or 3988293899 3468206646]]
Expand Down Expand Up @@ -194,7 +194,7 @@
end

it 'should correctly evaluate leaf node in audienceConditions' do
user_context.instance_variable_set(:@user_attributes, {'browser' => 'chrome'})
user_context.instance_variable_set(:@user_attributes, 'browser' => 'chrome')
experiment = typed_audience_config.get_experiment_from_key('audience_combinations_experiment')
experiment['audienceConditions'] = '3468206645'
customer_attr = Optimizely::CustomAttributeConditionEvaluator.new(user_context, spy_logger)
Expand All @@ -212,7 +212,7 @@

it 'should return nil when audience not found' do
experiment = config.experiment_key_map['test_experiment_with_audience']
user_context.instance_variable_set(:@user_attributes, {'browser_type' => 5.5})
user_context.instance_variable_set(:@user_attributes, 'browser_type' => 5.5)
experiment['audienceIds'] = %w[11110]

user_meets_audience_conditions, reasons = Optimizely::Audience.user_meets_audience_conditions?(config, experiment, user_context, spy_logger)
Expand All @@ -234,7 +234,7 @@

it 'should log and return false for user_meets_audience_conditions? evaluates audienceIds' do
experiment = config.experiment_key_map['test_experiment_with_audience']
user_context.instance_variable_set(:@user_attributes, {'browser_type' => 5.5})
user_context.instance_variable_set(:@user_attributes, 'browser_type' => 5.5)
experiment['audienceIds'] = %w[11154 11155]
experiment['audienceConditions'] = nil

Expand Down Expand Up @@ -284,7 +284,7 @@
end

it 'should log and return true for user_meets_audience_conditions? evaluates audienceConditions' do
user_context.instance_variable_set(:@user_attributes, {'lasers' => 45.5})
user_context.instance_variable_set(:@user_attributes, 'lasers' => 45.5)
experiment = typed_audience_config.get_experiment_from_key('audience_combinations_experiment')
experiment['audienceIds'] = []
experiment['audienceConditions'] = ['or', %w[or 3468206647 3988293898 3468206646]]
Expand Down Expand Up @@ -343,7 +343,7 @@
logging_hash = 'ROLLOUT_AUDIENCE_EVALUATION_LOGS'
logging_key = 'some_key'

user_context.instance_variable_set(:@user_attributes, {'lasers' => 45.5})
user_context.instance_variable_set(:@user_attributes, 'lasers' => 45.5)
experiment = typed_audience_config.get_experiment_from_key('audience_combinations_experiment')
experiment['audienceIds'] = []
experiment['audienceConditions'] = ['or', %w[or 3468206647 3988293898 3468206646]]
Expand Down
Loading
0